This repository has been archived by the owner. It is now read-only.

make Ctrl+Shift+Space select/deselect current item #1983

Closed
vanowm opened this Issue May 13, 2017 · 9 comments

Comments

2 participants
@vanowm

vanowm commented May 13, 2017

A common behaviour is when application allows select multiple list items that have checkboxes (using SHIFT/CTRL keys) hitting space would check/uncheck the checkboxes of all selected items.
Currently hitting space bar in would ignore all selected items but "current" one, making multiple selection totally useless.

Even right click has no actions for the selections.
image

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus May 13, 2017

Owner

The primary purpose of mult-track-selection is applying settings on the right to all of them at once. Select a couple of tracks, then change e.g. the track language to French and it will be set for all selected tracks. This includes enabling or disabling them via "Copy this item" at the top. See this short video as an example.

As for keyboard shortcuts: hitting return will do what you want.

Owner

mbunkus commented May 13, 2017

The primary purpose of mult-track-selection is applying settings on the right to all of them at once. Select a couple of tracks, then change e.g. the track language to French and it will be set for all selected tracks. This includes enabling or disabling them via "Copy this item" at the top. See this short video as an example.

As for keyboard shortcuts: hitting return will do what you want.

@vanowm

This comment has been minimized.

Show comment
Hide comment
@vanowm

vanowm May 13, 2017

May I ask why enter? This is not "common" behaviour of any application I've ever seen.
(numpad enter doesn't doesn't work, btw)

Also its not possible using just keyboard select multiple list items not in sequence (unless there is another arbitrary button I don't know that does this). Normally SHIFT + Up/Down selects items in sequence, while holding CTRL key would allow change position of "current" selection (the dotted border) without actually selecting it, then pressing space would add that item to the selection.
mkvtoolnix behaves differently CTRL + Up/Down moves selected items, SHIFT + CTRL +Up/Down changes the "current" position, however pressing SHIFT + CTRL + SPACE check/uncheck the checkbox of the "current" item only and SHIFT + CTRL + ENTER does nothing.

IMO it should be:
current = item with dotted border
select = item with blue background

Key combination Current action Proposed action
Up/Down move current and select single item move current and select single item
Space check/uncheck current item check/uncheck all selected items
CTRL + Up/Down move selected items move current position
CTRL + Space check/uncheck current item select/deselect current item without affecting other selected items
CTRL + SHIFT + Up/Down move current position move selected items
SHIFT + Up/Down move current position and add/remove this item to/from the selection * move current position and add/remove this item to/from the selection
SHIFT + Space check/uncheck current item check/uncheck current item

* it doesn't deselect items that were previously selected (for example via CTRL + Mouse Click)

vanowm commented May 13, 2017

May I ask why enter? This is not "common" behaviour of any application I've ever seen.
(numpad enter doesn't doesn't work, btw)

Also its not possible using just keyboard select multiple list items not in sequence (unless there is another arbitrary button I don't know that does this). Normally SHIFT + Up/Down selects items in sequence, while holding CTRL key would allow change position of "current" selection (the dotted border) without actually selecting it, then pressing space would add that item to the selection.
mkvtoolnix behaves differently CTRL + Up/Down moves selected items, SHIFT + CTRL +Up/Down changes the "current" position, however pressing SHIFT + CTRL + SPACE check/uncheck the checkbox of the "current" item only and SHIFT + CTRL + ENTER does nothing.

IMO it should be:
current = item with dotted border
select = item with blue background

Key combination Current action Proposed action
Up/Down move current and select single item move current and select single item
Space check/uncheck current item check/uncheck all selected items
CTRL + Up/Down move selected items move current position
CTRL + Space check/uncheck current item select/deselect current item without affecting other selected items
CTRL + SHIFT + Up/Down move current position move selected items
SHIFT + Up/Down move current position and add/remove this item to/from the selection * move current position and add/remove this item to/from the selection
SHIFT + Space check/uncheck current item check/uncheck current item

* it doesn't deselect items that were previously selected (for example via CTRL + Mouse Click)

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus May 13, 2017

Owner

It works how it works because it's the default Qt tree view control with its default key bindings when multi-selection is enabled. I'm not going to change that.

Owner

mbunkus commented May 13, 2017

It works how it works because it's the default Qt tree view control with its default key bindings when multi-selection is enabled. I'm not going to change that.

@vanowm

This comment has been minimized.

Show comment
Hide comment
@vanowm

vanowm May 13, 2017

Oh ok, but would you consider at least change behaviour of CTRL + SHIFT + SPACE = select current item without affecting previous selection?

vanowm commented May 13, 2017

Oh ok, but would you consider at least change behaviour of CTRL + SHIFT + SPACE = select current item without affecting previous selection?

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus May 13, 2017

Owner

How would that help you? You cannot move the current item without moving the selection.

Owner

mbunkus commented May 13, 2017

How would that help you? You cannot move the current item without moving the selection.

@vanowm

This comment has been minimized.

Show comment
Hide comment
@vanowm

vanowm May 13, 2017

Yes, you can CTRL + SHIFT + Up/Down

vanowm commented May 13, 2017

Yes, you can CTRL + SHIFT + Up/Down

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus May 13, 2017

Owner

Ah right. Yeah ok.

Owner

mbunkus commented May 13, 2017

Ah right. Yeah ok.

@mbunkus mbunkus changed the title from Space bar on multiple selected items should check/uncheck all selected items to make Ctrl+Shift+Space select/deselect current item May 13, 2017

@mbunkus mbunkus reopened this May 14, 2017

mbunkus added a commit that referenced this issue May 14, 2017

GUI: make Ctrl+Shift+Space toggle selection of current item in tree v…
…iews

This only applies to tree views that allow multiple selections.

Implements #1983.

@mbunkus mbunkus closed this May 14, 2017

@vanowm

This comment has been minimized.

Show comment
Hide comment
@vanowm

vanowm May 21, 2017

Well, somehow the topic was changed to something wasn't discussed about at all and the fix is not related to what this topic was originally about...
Right now there is still no way check/uncheck selected items all at once with keyboard, or via mouse right click
And now CTRL+SHIFT+SPACE does exactly what CTRL+SPACE supposed to do (as in commonly in most applications, including windows explorer)

vanowm commented May 21, 2017

Well, somehow the topic was changed to something wasn't discussed about at all and the fix is not related to what this topic was originally about...
Right now there is still no way check/uncheck selected items all at once with keyboard, or via mouse right click
And now CTRL+SHIFT+SPACE does exactly what CTRL+SPACE supposed to do (as in commonly in most applications, including windows explorer)

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus May 22, 2017

Owner

Right now there is still no way check/uncheck selected items all at once with keyboard, or via mouse right click

This is incorrect. As I've stated above:

  • Hitting enter will check/uncheck all selected items at once. With a single press of said key.
  • Using the mouse you can check/uncheck all selected items at once by changing the drop down box on the right labeled "copy this item". Yes, one such change applies to all selected items.
Owner

mbunkus commented May 22, 2017

Right now there is still no way check/uncheck selected items all at once with keyboard, or via mouse right click

This is incorrect. As I've stated above:

  • Hitting enter will check/uncheck all selected items at once. With a single press of said key.
  • Using the mouse you can check/uncheck all selected items at once by changing the drop down box on the right labeled "copy this item". Yes, one such change applies to all selected items.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.