This repository has been archived by the owner. It is now read-only.

GUI: Invalid value in total progress bar for multiple jobs running #2005

Closed
engycz opened this Issue Jun 6, 2017 · 8 comments

Comments

4 participants
@engycz

engycz commented Jun 6, 2017

How to reproduce: Start two jobs simultaneously
I will fix it.

Progress= 92, Total Progress= 46, m_queueNumDone=0, runningProgress= 92, m_toBeProcessed.count()=2, m_queueNumDone=0
Progress= 94, Total Progress= 47, m_queueNumDone=0, runningProgress= 94, m_toBeProcessed.count()=2, m_queueNumDone=0
Progress= 95, Total Progress= 47, m_queueNumDone=0, runningProgress= 95, m_toBeProcessed.count()=2, m_queueNumDone=0
Progress= 96, Total Progress= 48, m_queueNumDone=0, runningProgress= 96, m_toBeProcessed.count()=2, m_queueNumDone=0
Progress= 97, Total Progress= 48, m_queueNumDone=0, runningProgress= 97, m_toBeProcessed.count()=2, m_queueNumDone=0
Progress= 98, Total Progress= 49, m_queueNumDone=0, runningProgress= 98, m_toBeProcessed.count()=2, m_queueNumDone=0
Progress= 99, Total Progress= 49, m_queueNumDone=0, runningProgress= 99, m_toBeProcessed.count()=2, m_queueNumDone=0
Progress=100, Total Progress= 50, m_queueNumDone=0, runningProgress=100, m_toBeProcessed.count()=2, m_queueNumDone=0
Progress=  1, Total Progress= 33, m_queueNumDone=1, runningProgress=  1, m_toBeProcessed.count()=2, m_queueNumDone=1
Progress=  2, Total Progress= 34, m_queueNumDone=1, runningProgress=  2, m_toBeProcessed.count()=2, m_queueNumDone=1
Progress=  3, Total Progress= 34, m_queueNumDone=1, runningProgress=  3, m_toBeProcessed.count()=2, m_queueNumDone=1
Progress=  4, Total Progress= 34, m_queueNumDone=1, runningProgress=  4, m_toBeProcessed.count()=2, m_queueNumDone=1
Progress=  5, Total Progress= 35, m_queueNumDone=1, runningProgress=  5, m_toBeProcessed.count()=2, m_queueNumDone=1
Progress=  6, Total Progress= 35, m_queueNumDone=1, runningProgress=  6, m_toBeProcessed.count()=2, m_queueNumDone=1
Progress=  8, Total Progress= 36, m_queueNumDone=1, runningProgress=  8, m_toBeProcessed.count()=2, m_queueNumDone=1
Progress= 10, Total Progress= 36, m_queueNumDone=1, runningProgress= 10, m_toBeProcessed.count()=2, m_queueNumDone=1
@remuxer32

This comment has been minimized.

Show comment
Hide comment
@remuxer32

remuxer32 Jun 10, 2017

Collaborator

Thank you for your fix. At the moment Moritz Bunkus (the owner of MKVToolNix) is out of town, and he will be unavailable for several weeks, so you will have to be patient for any action from him. Personally I'm not able to tell you whether your fix (change) is correct or not; only the author can.

About your entry in the NEWS.md: when we add an entry to the "Bug fixes" section, we always add the word Fixes before a number of an issue. For example: Fixes #21523. Therefore in your case the correct form should be like this:

MKVToolNix GUI: fixed computation of value of total progress bar for multiple jobs running. Fixes #2005.

I know it's a trifle (just one word) but very important (at least for me). Thanks to that we know which issue was fixed (the word Fixes helps us to localize a proper issue, and also informs us that the particular one was successfully fixed).

The similar situation is when we add a new entry to the "New features and enhancements" section. Then we write the word Implements before a number of an issue. For example: Implements #47856.

Collaborator

remuxer32 commented Jun 10, 2017

Thank you for your fix. At the moment Moritz Bunkus (the owner of MKVToolNix) is out of town, and he will be unavailable for several weeks, so you will have to be patient for any action from him. Personally I'm not able to tell you whether your fix (change) is correct or not; only the author can.

About your entry in the NEWS.md: when we add an entry to the "Bug fixes" section, we always add the word Fixes before a number of an issue. For example: Fixes #21523. Therefore in your case the correct form should be like this:

MKVToolNix GUI: fixed computation of value of total progress bar for multiple jobs running. Fixes #2005.

I know it's a trifle (just one word) but very important (at least for me). Thanks to that we know which issue was fixed (the word Fixes helps us to localize a proper issue, and also informs us that the particular one was successfully fixed).

The similar situation is when we add a new entry to the "New features and enhancements" section. Then we write the word Implements before a number of an issue. For example: Implements #47856.

@engycz

This comment has been minimized.

Show comment
Hide comment
@engycz

engycz Jun 11, 2017

Thanks for the suggestion. Fixed.

engycz commented Jun 11, 2017

Thanks for the suggestion. Fixed.

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Jun 11, 2017

Owner

Thanks for the report & the PR; highly appreciated. As @mkver has said I'm currently out sick. I'll take care of this (testing & merging your PR) in a couple of weeks.

Owner

mbunkus commented Jun 11, 2017

Thanks for the report & the PR; highly appreciated. As @mkver has said I'm currently out sick. I'll take care of this (testing & merging your PR) in a couple of weeks.

@remuxer32

This comment has been minimized.

Show comment
Hide comment
@remuxer32

remuxer32 Jun 11, 2017

Collaborator

As @mkver has said I'm currently out sick.

Well, in THIS particular issue @mkver hasn't said anything yet; that was me, remuxer32 (see above again, please, and correct a mistake) ☺.

Collaborator

remuxer32 commented Jun 11, 2017

As @mkver has said I'm currently out sick.

Well, in THIS particular issue @mkver hasn't said anything yet; that was me, remuxer32 (see above again, please, and correct a mistake) ☺.

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Jun 11, 2017

Owner

Oops, you're right, of course. Sorry :)

Owner

mbunkus commented Jun 11, 2017

Oops, you're right, of course. Sorry :)

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Jun 16, 2017

Owner

Works fine, merged, thanks.

Owner

mbunkus commented Jun 16, 2017

Works fine, merged, thanks.

@sneaker2

This comment has been minimized.

Show comment
Hide comment
@sneaker2

sneaker2 Jul 4, 2017

For me the bar in the GUI (bottom right) now always goes empty after having completed the queue. Is this intended?
Top: 12.0.0, Bottom: 13.0.0
mkvmerge_100perc_progress-fs8

sneaker2 commented Jul 4, 2017

For me the bar in the GUI (bottom right) now always goes empty after having completed the queue. Is this intended?
Top: 12.0.0, Bottom: 13.0.0
mkvmerge_100perc_progress-fs8

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Jul 5, 2017

Owner

That's definitely not intentional on my party.

Owner

mbunkus commented Jul 5, 2017

That's definitely not intentional on my party.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.