This repository has been archived by the owner. It is now read-only.

Tags and wiki don't match #2022

Closed
mkver opened this Issue Jun 23, 2017 · 4 comments

Comments

3 participants
@mkver

mkver commented Jun 23, 2017

Hello,

according to wiki page about tags the NUMBER_OF_BYTES field is supposed to contain the number of bytes in the track before the Matroska track compression is applied. But this is not the way it is currently handled by mkvmerge: Using zlib or not changes the NUMBER_OF_BYTES field. This can be proven with any picture based subtitles.

Greetings
Andi

PS: That page contains some typos etc.: "present int he track": in the. "For mkvmerge this contains tag": this tag contains. "In mmg you can add that option": mmg is outdated. "disable reading tags fromt the source file": from the.

@remuxer32

This comment has been minimized.

Show comment
Hide comment
@remuxer32

remuxer32 Jun 24, 2017

Collaborator

Thanks. Will be fixed soon, don't worry. Except typos, there are also missing commas; I will add them, of course.

Collaborator

remuxer32 commented Jun 24, 2017

Thanks. Will be fixed soon, don't worry. Except typos, there are also missing commas; I will add them, of course.

@mkver

This comment has been minimized.

Show comment
Hide comment
@mkver

mkver Jun 24, 2017

This sounds as if you are sure that it is the wiki page that is wrong. Are you sure about this? Maybe it describes what Moritz had in mind, but hasn't implemented due to a bug (in mkvmerge, not the documentation).

mkver commented Jun 24, 2017

This sounds as if you are sure that it is the wiki page that is wrong. Are you sure about this? Maybe it describes what Moritz had in mind, but hasn't implemented due to a bug (in mkvmerge, not the documentation).

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Jun 24, 2017

Owner

Thanks for reporting this. The documentation is correct in this case; mkvmerge's behavior is buggy. My intention was to have NUMBER_OF_BYTES reflect the number of bytes as they come out of the encoder (so that the value can actually be used to calculcate the number of bits per second in a way that's useful to users and not confusing), and that number is the one before any of Matroska's content encoding schemes is applied.

Owner

mbunkus commented Jun 24, 2017

Thanks for reporting this. The documentation is correct in this case; mkvmerge's behavior is buggy. My intention was to have NUMBER_OF_BYTES reflect the number of bytes as they come out of the encoder (so that the value can actually be used to calculcate the number of bits per second in a way that's useful to users and not confusing), and that number is the one before any of Matroska's content encoding schemes is applied.

@remuxer32

This comment has been minimized.

Show comment
Hide comment
@remuxer32

remuxer32 Jun 24, 2017

Collaborator

My previous comment only applied to errors in the wiki page (such as typos, missing commas etc.). I didn't say anything about NUMBER_OF_BYTES as I wasn't sure regarding that, of course.

I don't agree with removing the "documentation" label because the wiki page had errors, too, so the label is suitable for that (like in the previous report where errors in wiki were reported as well). In this case we have two problems: wrong mkvmerge's behaviour (which was successfully fixed) and errors in the wiki page: therefore the two labels — "mkvmerge" & "documentation" — are correct in my opinion.

Anyway, I have already fixed those errors (typos, missing commas, one missing colon etc.). See:

Collaborator

remuxer32 commented Jun 24, 2017

My previous comment only applied to errors in the wiki page (such as typos, missing commas etc.). I didn't say anything about NUMBER_OF_BYTES as I wasn't sure regarding that, of course.

I don't agree with removing the "documentation" label because the wiki page had errors, too, so the label is suitable for that (like in the previous report where errors in wiki were reported as well). In this case we have two problems: wrong mkvmerge's behaviour (which was successfully fixed) and errors in the wiki page: therefore the two labels — "mkvmerge" & "documentation" — are correct in my opinion.

Anyway, I have already fixed those errors (typos, missing commas, one missing colon etc.). See:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.