This repository has been archived by the owner. It is now read-only.

json.hpp include path changed #2048

Closed
marillat opened this Issue Jul 17, 2017 · 3 comments

Comments

2 participants
@marillat

marillat commented Jul 17, 2017

Hi,

Debian force the installation of json.hpp in /usr/include when upstream is supposed to install this file in /usr/include/nlohmann

This issue should be fixed in the next Debian package and thus mkvtoolnix will not find json.hpp

Tell me if you intent to do a new release soon.

See https://bugs.debian.org/868112

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Jul 17, 2017

Owner

I see. I'll look into it. The next version will likely be released in two, maybe three weeks.

Owner

mbunkus commented Jul 17, 2017

I see. I'll look into it. The next version will likely be released in two, maybe three weeks.

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Jul 17, 2017

Owner

BTW, that Debian bug talks about $libdir/nlohmann/json.hpp. I can only hope that this is a typo, and that $includedir/nlohmann/json.hpp was actually meant. The AUR package mentioned installs the file as /usr/include/nlohnmann/json.hpp. And that's what I'll make configure check for, definitely not in /usr/lib.

nlohmann's json.hpp is a header-only "library". Therefore talking about $libdir doesn't make much sense…

Owner

mbunkus commented Jul 17, 2017

BTW, that Debian bug talks about $libdir/nlohmann/json.hpp. I can only hope that this is a typo, and that $includedir/nlohmann/json.hpp was actually meant. The AUR package mentioned installs the file as /usr/include/nlohnmann/json.hpp. And that's what I'll make configure check for, definitely not in /usr/lib.

nlohmann's json.hpp is a header-only "library". Therefore talking about $libdir doesn't make much sense…

@marillat

This comment has been minimized.

Show comment
Hide comment
@marillat

marillat Jul 17, 2017

Yes, I think it is a typo in the bug report.

marillat commented Jul 17, 2017

Yes, I think it is a typo in the bug report.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.