This repository has been archived by the owner. It is now read-only.

File modified message when opening file over network with MKVToolNix GUI header editor #2097

Closed
deusxanime opened this Issue Sep 15, 2017 · 3 comments

Comments

3 participants
@deusxanime

deusxanime commented Sep 15, 2017

When opening an mkv file over the network in Header Editor, if I make a change and save, or seemingly even just after a while, and then try to save again I get message with title "File has been modified" (see screenshot for full message) and I have to close and reopen the file to make anymore changes. This gets cumbersome when editing multiple things like default/enabled/forced flags, name, language, etc like I like to do when I get new files.

I have been able to get around this in the past by using MKVToolNix GUI directly on my file server which was previously a Windows Server 2012. By opening it directly on the local filesystem on the server I wouldn't get the file changed message no matter how many times I changed/saved it. I've just rebuilt my NAS server and now using unRAID for the OS rather than Windows, so that is no longer an option. I've seen this problem for a long time, maybe back since v8 or v9 when I first started using MKVToolNix GUI, and it still persists running v15.0.0 today.

I tried opening it via UNC path as well as mapped drive, but neither improves it.

image

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Sep 16, 2017

Owner

Thanks for the report. I'll look into it. It probably is due to OS-level caching on both the client and the file server, and thereby resulting in different file modification timestamps.

At the moment I'm not sure I can reasonably check for external modification anymore, so maybe I'll just remove the check altogether.

Owner

mbunkus commented Sep 16, 2017

Thanks for the report. I'll look into it. It probably is due to OS-level caching on both the client and the file server, and thereby resulting in different file modification timestamps.

At the moment I'm not sure I can reasonably check for external modification anymore, so maybe I'll just remove the check altogether.

@mbunkus

This comment has been minimized.

Show comment
Hide comment
@mbunkus

mbunkus Sep 16, 2017

Owner

Yeah it's due caching. Here's data from one of my tests:

  1. First time "save" is called is at 12:29:46. Saving takes less than one second from the GUI's POV. Therefore it stores 12:29:46 as the last known modification time.
  2. Second time "save" is called is at 12:31:39. The GUI now queries the operating system for the file's "last modification timestamp". The OS returns 12:30:05, which is higher than the timestamp remembered in step 1. Therefore the error is shown.
Owner

mbunkus commented Sep 16, 2017

Yeah it's due caching. Here's data from one of my tests:

  1. First time "save" is called is at 12:29:46. Saving takes less than one second from the GUI's POV. Therefore it stores 12:29:46 as the last known modification time.
  2. Second time "save" is called is at 12:31:39. The GUI now queries the operating system for the file's "last modification timestamp". The OS returns 12:30:05, which is higher than the timestamp remembered in step 1. Therefore the error is shown.

@remuxer32 remuxer32 changed the title from File modified message when opening file over network with MLVToolNix GUI header editor to File modified message when opening file over network with MKVToolNix GUI header editor Sep 16, 2017

@mbunkus mbunkus closed this in bfc4d7c Sep 16, 2017

@remuxer32

This comment has been minimized.

Show comment
Hide comment
@remuxer32

remuxer32 Sep 16, 2017

Collaborator

Fixed in bfc4d7c.

Collaborator

remuxer32 commented Sep 16, 2017

Fixed in bfc4d7c.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.