Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
support colr atom #1804
Thanks for the updated pull request. I'll leave notes inline.
A general note though: your git repository is not up to date regarding the
Please update your submodules re-base this pull request (together with the other changes I'll ask about). Thanks.
Thanks for the push. Apart from the line comments that I've added there's also the issue that your commit still updates the
libmatroska sub-modules. The commit shouldn't modify them at all for this functionality.
When I do ./configure
I have installed boost 1.63.0 but the problem still persists.
Could you have a look? Is it related to compiler? my boost is built and installed using gcc-4.8 but the project requires gcc-4.9.
I don't have systems with such old gcc versions anymore, and I've never encountered this error myself. I don't think I can really help you with this.
You absolutely need to use gcc 4.9 or newer in order to compile MKVToolNix. The source code uses features that gcc 4.8 simply doesn't support.
added a commit
this pull request
Apr 22, 2017
Hi, Moritz Thank you very much for fixing my code and merging the changes. That is very helpful for our work. best, Chao Chen Chao Chen…
On Sat, Apr 22, 2017 at 8:01 AM, Moritz Bunkus ***@***.***> wrote: Thanks. I've merged this version and fixed a couple of issues in cd742ed <cd742ed>. It'll be part of the next release. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1804 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGvyQ82ErYUkMrQ1ESFgqfO8d0PbJ8VMks5ryhZggaJpZM4KqsCR> .