Fixing a few issues in the Tracker #406

Merged
merged 3 commits into from Jan 1, 2013

Conversation

Projects
None yet
3 participants
@Glitchfinder
Member

Glitchfinder commented Jan 1, 2013

This pull request is intended to patch a few different issues currently in the issue tracker.

  • Commt @0e853d44b7369826dfbd1b442d28a4185209b0ab fixes a bug where the repair skill could remove all enchantments from an item but leave the enchantment effect in place, preventing it from being re-enchanted. This addresses issue #346.
  • Commit @d33334708dc8e8c2cfced0bc320990beda80a9f2 fixes a potential stack overflow involving recursion by switching from an unnecessary binary tree to a simple ArrayList. This addresses issue #264.
  • Commit @707a388c513acb479ddf7684e845eb8561bedc8f fixes a bug where dropped items do not retain any customized NBT data. This addresses issue #337.

@ghost ghost assigned Glitchfinder Jan 1, 2013

@Glitchfinder Glitchfinder referenced this pull request Jan 1, 2013

Closed

Additions to mcMMO #301

Glitchfinder added a commit that referenced this pull request Jan 1, 2013

Merge pull request #406 from Glitchfinder/master
Fixing a few issues in the Tracker

@Glitchfinder Glitchfinder merged commit bfdb825 into mcMMO-Dev:master Jan 1, 2013

@Bestle

This comment has been minimized.

Show comment Hide comment
@Bestle

Bestle Jan 1, 2013

Contributor

Surely using the new ItemMeta API to remove the enchantments would be a lot nicer than using reflection.

Contributor

Bestle commented on 0e853d4 Jan 1, 2013

Surely using the new ItemMeta API to remove the enchantments would be a lot nicer than using reflection.

This comment has been minimized.

Show comment Hide comment
@TfT-02

TfT-02 Jan 1, 2013

Member

As far as I'm aware, that method doesn't work. This isn't implemented properly in the Bukkit API.

Member

TfT-02 replied Jan 1, 2013

As far as I'm aware, that method doesn't work. This isn't implemented properly in the Bukkit API.

This comment has been minimized.

Show comment Hide comment
@Glitchfinder

Glitchfinder Jan 1, 2013

Member

Bestle, ItemMeta doesn't touch enchantments. At all. The whole issue was that bukkit doesn't remove the NBT tag for enchantments when the last enchantment is removed, and an item with an empty enchantment tag is still treated as an enchanted item.

Member

Glitchfinder replied Jan 1, 2013

Bestle, ItemMeta doesn't touch enchantments. At all. The whole issue was that bukkit doesn't remove the NBT tag for enchantments when the last enchantment is removed, and an item with an empty enchantment tag is still treated as an enchanted item.

This comment has been minimized.

Show comment Hide comment
@Bestle

Bestle Jan 1, 2013

Contributor

This was fixed in Bukkit itself.

Contributor

Bestle replied Jan 1, 2013

This was fixed in Bukkit itself.

This comment has been minimized.

Show comment Hide comment
@Glitchfinder

Glitchfinder Jan 1, 2013

Member

That was mentioned in IRC last night, For the moment, I'm leaving the code in place because not everyone will update bukkit and all of their plugins at the same time, and so this actually will help a few people.

Member

Glitchfinder replied Jan 1, 2013

That was mentioned in IRC last night, For the moment, I'm leaving the code in place because not everyone will update bukkit and all of their plugins at the same time, and so this actually will help a few people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment