From 48af24a0bb7a8321ef8ac21576bb2f10305b585c Mon Sep 17 00:00:00 2001
From: mihai-adrian <mihai.carare.dev@gmail.com>
Date: Mon, 12 Aug 2019 10:41:01 +0300
Subject: [PATCH] fixes #4434 - made buttons for collection home list row more
 accessible and aligned 3 dot menu with individual tabs close button

set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
---
 .../res/layout/collection_home_list_row.xml    | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/app/src/main/res/layout/collection_home_list_row.xml b/app/src/main/res/layout/collection_home_list_row.xml
index c144107e5789..e61b0ab21e3e 100644
--- a/app/src/main/res/layout/collection_home_list_row.xml
+++ b/app/src/main/res/layout/collection_home_list_row.xml
@@ -78,32 +78,30 @@
                 app:layout_constraintBottom_toBottomOf="parent"
                 app:layout_constraintEnd_toStartOf="@id/collection_share_button"
                 app:layout_constraintStart_toStartOf="@id/collection_title"
-                app:layout_constraintTop_toBottomOf="@id/collection_share_button"
+                app:layout_constraintTop_toBottomOf="@id/collection_title"
                 tools:text="@tools:sample/lorem/random" />
 
         <ImageButton
                 android:id="@+id/collection_share_button"
-                android:layout_width="24dp"
-                android:layout_height="24dp"
-                android:layout_marginStart="16dp"
-                android:layout_marginEnd="30dp"
+                android:layout_width="48dp"
+                android:layout_height="48dp"
                 android:background="?android:attr/selectableItemBackgroundBorderless"
                 android:contentDescription="@string/share_button_content_description"
                 android:src="@drawable/ic_hollow_share"
                 app:layout_constraintEnd_toStartOf="@id/collection_overflow_button"
+                app:layout_constraintBottom_toBottomOf="@id/collection_icon"
                 app:layout_constraintTop_toTopOf="@id/collection_icon" />
 
         <ImageButton
                 android:id="@+id/collection_overflow_button"
-                android:layout_width="24dp"
-                android:layout_height="24dp"
-                android:layout_marginTop="16dp"
-                android:layout_marginEnd="4.5dp"
+                android:layout_width="48dp"
+                android:layout_height="48dp"
                 android:background="?android:attr/selectableItemBackgroundBorderless"
                 android:contentDescription="@string/collection_menu_button_content_description"
                 android:src="@drawable/ic_menu"
                 app:layout_constraintEnd_toEndOf="parent"
-                app:layout_constraintTop_toTopOf="parent" />
+                app:layout_constraintTop_toTopOf="@id/collection_icon"
+                app:layout_constraintBottom_toBottomOf="@id/collection_icon"/>
 
         <View
                 android:id="@+id/selected_border"