From fed4c17476a68379cd99d3061acdfbd807ccd954 Mon Sep 17 00:00:00 2001
From: mihai-adrian <mihai.carare.dev@gmail.com>
Date: Thu, 1 Aug 2019 16:46:19 +0300
Subject: [PATCH] fixes #4434 - made close button for collections more
 accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for #4193 - close button for tabs
---
 app/src/main/res/layout/tab_in_collection.xml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/src/main/res/layout/tab_in_collection.xml b/app/src/main/res/layout/tab_in_collection.xml
index e0abc6ed716c..d5dfd9d8cbfe 100644
--- a/app/src/main/res/layout/tab_in_collection.xml
+++ b/app/src/main/res/layout/tab_in_collection.xml
@@ -21,6 +21,7 @@
 
         <ImageView
                 android:id="@+id/collection_tab_icon"
+                android:importantForAccessibility="no"
                 android:layout_width="24dp"
                 android:layout_height="24dp"
                 android:layout_marginTop="23dp"
@@ -62,16 +63,15 @@
 
         <ImageButton
                 android:id="@+id/collection_tab_close_button"
-                android:layout_width="8dp"
-                android:layout_height="8dp"
+                android:layout_width="48dp"
+                android:layout_height="48dp"
                 android:background="?android:attr/selectableItemBackgroundBorderless"
                 android:contentDescription="@string/close_tab"
                 android:src="@drawable/ic_close"
-                android:layout_marginTop="13dp"
-                android:layout_marginEnd="13dp"
                 android:alpha="0.8"
                 app:layout_constraintEnd_toEndOf="parent"
-                app:layout_constraintTop_toTopOf="parent"/>
+                app:layout_constraintTop_toTopOf="parent"
+                app:layout_constraintBottom_toBottomOf="parent"/>
 
         <View
                 android:id="@+id/divider_line"