Adding req.matchedVersion() #635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -203,6 +203,14 @@ Request.prototype.getVersion = function getVersion() { | |||
| }; | |||
| Request.prototype.version = Request.prototype.getVersion; | |||
|
|
|||
| Request.prototype.matchedVersion = function matchedVersion() { | |||
| if (this._matchedVersion !== undefined) | |||
This new method makes it easier for routes to determine which version from their list of supported versions matched the accept-version header string. Rebase added committed: Fixing stylistic issues with pull request
|
Sorry about that stylistic faux paux @gergelyke. I fixed the if/else format and squashed the stylistic change commit into the original. |
|
Hey @nathanpeck , thanks so much for doing this. In order to merge, could you
|
| @@ -367,6 +367,7 @@ Router.prototype.find = function find(req, res, callback) { | |||
| } | |||
| } | |||
|
|
|||
| var maxV; | |||
There was a problem hiding this comment.
Can you move this up to the top of the function, with the rest of the variable declarations?
|
@nathanpeck Almost there, just a couple small changes (and merge conflict resolutions) and this is good to go! |
|
Closing in favor of #842 which fixes the merge conflict and JSCS errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a route is defined as responding to multiple version numbers then if the client supplies a version range that it can accept such as
accept-version: <2.2.0it can be useful for the route to know exactly which version number from its array of supported versions matched the clients version specification.req.version() already exposes the clients version string but it is often a range such as <2.2.0 or 2.*
req.matchedVersion() allows a route which matches versions 2.0.0, 2.1.0, and 2.2.0 to know that a client who specified
accept-version: <2.2.0reached the route because 2.1.0 matched the request header.This pull request includes documentation, and a test.