Added typeof check to the jsonp callback #729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbjordan
changed the title
typeof check to the jsonp callback
mbjordan
changed the title
typeof check to the jsonp callback
|
Hi, thanks for contributing! Could you please add a unit test for this? Please prefix the name with "gh #729". |
|
The test has been added, however the tests failed due to using version 3.0.0 on Travis and my PR is from 2.8.4. Thinking I should close this PR and open a new one with the most recent version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting data via a jsonp request, its useful to have a check that ensures the callback function is defined before calling it. This prevents a reference error from being thrown in the browser if a function name is not defined when data is returned.