Stuart McCulloch mcculls

  • Joined on

Organizations

@sonatype @jenkinsci @ops4j @hudson @hudson2-plugins @hudson3-plugins
mcculls commented on pull request sonatype/nexus-perf#1
@mcculls

Ah... the latest official Maven release on central is 3.3.3 - the 3.3.4 release should be out in the next few weeks, but it has yet to be staged an…

mcculls commented on pull request sonatype/nexus-perf#1
@mcculls

+1 with minor comments ... wrt. scorched earth, might as well remove that

mcculls commented on pull request sonatype/nexus-perf#1
@mcculls

just wondering where the 3.3.4 version comes from - is it related to the upcoming maven release?

mcculls commented on pull request sonatype/nexus-perf#1
@mcculls

FYI, several java and text files have gone from 0644 to 0755 (executable) which doesn't look intentional

mcculls commented on pull request sonatype/nexus-perf#1
@mcculls

is this exclusion (and the one below) really needed?

mcculls commented on pull request sonatype/nexus-oss#1534
@mcculls

+1 btw, what was the result of testing 2.0-beta1?

mcculls commented on pull request sonatype/nexus-oss#1533
@mcculls

makes sense to me

mcculls commented on pull request sonatype/nexus-oss#1533
@mcculls

good idea

mcculls commented on pull request sonatype/nexus-oss#1533
@mcculls

I find both just as readable, no objection if you want to use the new version

mcculls commented on pull request sonatype/nexus-oss#1531
@mcculls

+1

mcculls commented on pull request sonatype/nexus-oss#1502
@mcculls

+1 thanks

mcculls commented on pull request sonatype/nexus-oss#1502
@mcculls

Minor: only nuget appears to log this, would be nice to have the same logging in raw and maven as well

mcculls commented on pull request sonatype/nexus-oss#1502
@mcculls

Is this enough? What happens if the blob attached to the asset changes, in that case the attribute map will already contain a last-modified date an…

@mcculls
  • @mcculls 94961bc
    Merge remote-tracking branch 'upstream/master'
  • @sameb abc78c3
    Merge pull request #942 from tavianator/skip-static-interface-methods
  • 1 more commit »
mcculls commented on pull request sonatype/nexus-oss#1526
@mcculls

At first glance this appears to wait for the store to load and then click, so maybe waitForStoreToLoadThenClick is more descriptive? Though I'm not…

mcculls commented on pull request sonatype/nexus-oss#1526
@mcculls

maybe add a comment why these are necessary?

mcculls commented on pull request sonatype/nexus-oss#1526
mcculls commented on pull request sonatype/nexus-oss#1504
@mcculls

looks reasonable +1

mcculls deleted branch wait-for-nx-header-signin at sonatype/nexus-oss
mcculls commented on pull request sonatype/nexus-oss#1532
@mcculls

+1 assuming the FIXME is resolved before merging

mcculls commented on pull request sonatype/nexus-oss#1522
@mcculls

+1

mcculls commented on pull request sonatype/nexus-oss#1530
@mcculls

+1

mcculls commented on pull request sonatype/nexus-oss#1497
@mcculls

+1 tested locally, looks ok

mcculls commented on pull request sonatype/nexus-oss#1527
@mcculls

+1

mcculls commented on pull request sonatype/nexus-oss#1529
@mcculls

+1

mcculls commented on pull request sonatype/nexus-oss#1529
@mcculls

Just for information: this will still work with Provider<HttpClient> as the @Typed details take precedent, but using the more descriptive type in t…

mcculls commented on pull request sonatype/nexus-oss#1502
@mcculls

@cstamas don't mind if you merge them or not (just pointing out that might be convenient to do so rather than have related methods sitting in a sep…

mcculls commented on pull request sonatype/nexus-oss#1502
@mcculls

OK, as long as you can relate the different messages that should be enough

mcculls commented on pull request sonatype/nexus-oss#1502
@mcculls

OK, anything else we can log to help tie the expired cache to the resource? Just thinking it might make it easier to trace things when there are in…