Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Industrial furnace poor performance in Futurepack-1.12.2-26.3.123 #418

Closed
ProsperCraft opened this issue Mar 6, 2018 · 9 comments

Comments

Projects
None yet
2 participants
@ProsperCraft
Copy link

commented Mar 6, 2018

A single furnace was ticking at 6656

2018-03-06_07 01 49
2018-03-06_07 05 20
2018-03-06_07 05 08
2018-03-06_07 05 10
2018-03-06_07 05 12
2018-03-06_07 08 36
2018-03-06_07 08 42
2018-03-06_07 08 48

Here is a timings report.
https://timings.aikar.co/?id=8508745ac9ac43468fe96fb1cb68a1d2

Another laggoggles profile -

2018-03-06_07 11 10

Here is a sampler report to open in VisualVM
furnace.zip

Here is a warmroast report-
Warmroast.zip

@mcenderdragon

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2018

I am not sure if I can do much about this, as this furnace has a lot of recipes and needs to check for them.

@ProsperCraft

This comment has been minimized.

Copy link
Author

commented Mar 6, 2018

What if you check less frequently? That one furnace is ticking at 7066 right now, and it's not being used.

@ProsperCraft

This comment has been minimized.

Copy link
Author

commented Mar 6, 2018

Can you do something like - is there work? no...idle 15 seconds.

@mcenderdragon

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2018

well you decide through the RAM speed, and if there are items inside it will check if a recipe is working. I have tested some stuff but I dont know if they had a large impact.

@mcenderdragon

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2018

I made a few improves, please test if they had a large impact for your setup: 26.3.155

@mcenderdragon

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2018

Could you check if the industrial furnace has also this problem ?

@ProsperCraft

This comment has been minimized.

Copy link
Author

commented Mar 6, 2018

You totally fixed it!

I cloned the server, logged in, verified it was still acting badly, then upgraded to this new version, and this is the result.
2018-03-06_11 34 12
2018-03-06_11 34 18

@ProsperCraft

This comment has been minimized.

Copy link
Author

commented Mar 6, 2018

Please push so we can enjoy it :)

@mcenderdragon

This comment has been minimized.

Copy link
Owner

commented Mar 6, 2018

well a better term would be hidden, I let them wait a second if no recipes were found, and I improved the recipe searching, (I used some bad vanilla methods)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.