Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tile firmware effect messages #137

Merged
merged 9 commits into from
Mar 19, 2021
Merged

Conversation

exking
Copy link
Collaborator

@exking exking commented Dec 30, 2019

Add support for the GetTileEffect, SetTileEffect and StateTileEffect messages as documented here

@ceboxsell
Copy link

Did some testing and it worked but needs documenting in readme and refactoring.

@exking
Copy link
Collaborator Author

exking commented Jan 3, 2020

Added a couple README entries, thanks. I'm not sure if I need to copy the complete description from the API Docs as it may change in the future. I've also added the MultiZone Effect messages, but for some odd reason my Z2 Strip does not seem to react. Sending "SetMultiZoneEffect" and then "GetMultiZoneEffect" does reflect the parameters, but no actual "effect" is running. Very odd.

@ceboxsell
Copy link

I will do some testing on my z strip as well. Thanks for this.

@ceboxsell
Copy link

So tested set multizone effect and all good.
strip.set_multizone_effect(1123,1,3000)
and the get received.
{'instanceid': 1123, 'type': 1, 'speed': 3000, 'duration': 0, 'parameters': [0, 0, 0, 0, 0, 0, 0, 0]}

So maybe you forgot to set your speed value ? a value of 0 means no movement so it would look like it didn't work.

@exking
Copy link
Collaborator Author

exking commented Jan 5, 2020

Thanks for testing! Mine does return the correct GetMultizoneEffect showing my speed, parameters, (if duration is specified - it actually counts it down), etc, but Z strip itself does not react. I've noticed it won't react to the Move effect button on the iPhone either, so maybe it's hosed.

@exking exking requested a review from mclarkk February 5, 2020 04:52
@LinqLover
Copy link

I've noticed it won't react to the Move effect button on the iPhone either, so maybe it's hosed.

Then the API is not implemented perfectly in that respect - what's the overall state of this PR? I'm looking forward to using it in production! :D

@mclarkk mclarkk merged commit e0df813 into mclarkk:master Mar 19, 2021
@mclarkk
Copy link
Owner

mclarkk commented Mar 19, 2021

Merged! I made some changes mostly to the product file generation script reflecting updates to the way that products.py is formatted. Since it is a utility, that script has been moved into the core lifxlan folder instead of examples.

Thanks for all the great work writing and testing the Tile effects messages!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants