Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anything not in the inital classpath cannot provide a ITransformationService #22

Closed
ichttt opened this issue Apr 25, 2019 · 2 comments
Closed

Comments

@ichttt
Copy link
Member

ichttt commented Apr 25, 2019

The ITransformationService map is populated very early in the cycle, so only anything that is not on the launch class path wil lnot be scanned for ITransformationServices.
This mean 3rd party class transformation providers (like Mixin, Optifine, etc) have no access to ILaunchPluginService (which is intended IIRC) AND no access to ITransformationService (which they should have IMO, as it has a much ITransformers are much more locked down)

@cpw
Copy link
Member

cpw commented May 11, 2019

Note that mixin should not be loading as an ITransformationService, it should be loading, via the classpath, as an ILaunchPluginService. However, the point stands. Transformers need to be able to offer additional transformers to the system, for subsequent loading.

@cpw
Copy link
Member

cpw commented May 27, 2019

The newest release allows plugging in an "early discovery service" to facilitate this. However, it's still not what Mixin should be using.

@cpw cpw closed this as completed May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants