New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 compatibility #2

Merged
merged 2 commits into from May 20, 2016

Conversation

Projects
None yet
2 participants
@lucasb-eyer
Contributor

lucasb-eyer commented Apr 7, 2016

I noticed I can't use these scripts from python3. This PR should make the code work in both py2 and py3.

For simpler reviewing, I split it into 2 commits, the first should only be the print changes and the second addresses all other incompatibilities.

Note that this is not the same as straight 2to3 as the result of that wouldn't run in py2. Note also that I couldn't test in py2, so while I'm confident I didn't break anything, I recommend you give it a quick try before merging.

@mcordts mcordts merged commit a3bced5 into mcordts:master May 20, 2016

@mcordts

This comment has been minimized.

Show comment
Hide comment
@mcordts

mcordts May 20, 2016

Owner

The PR is now tested in Python 2.7 and merged. Thank you!

Owner

mcordts commented May 20, 2016

The PR is now tested in Python 2.7 and merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment