mcos deleted branch feature/http-exception-factory at mcos/Paulus
mcos commented on pull request Rican7/Paulus#15
@mcos

Thanks trevor!

@mcos
  • @mcos caf9956
    I dun goofed on a namespace. Ooops.
@mcos
  • @mcos b391b21
    Cleanup of docblocks. Soft tabbing things.
@mcos
  • @mcos 776ab5a
    Cleanup of docblocks. Soft tabbing things.
@mcos
  • @mcos 7a0c2fe
    Rename the new factory to `ApiExceptionFactory` and move it out of the
mcos pushed to master at mcos/ptrto
@mcos
  • @mcos acabdbb
    Add support for `interface` types
mcos pushed to master at mcos/ptrto
@mcos
mcos pushed to master at mcos/ptrto
@mcos
  • @mcos 38880dc
    Minumum 15 pieces of flair.
mcos commented on pull request Rican7/Paulus#15
@mcos

Cool. I'll update on the bus tomorrow.

mcos commented on pull request Rican7/Paulus#15
@mcos

Yeah. You'd be cool with ApiExceptionFactory and move it out of the Standard namespace?

mcos pushed to master at mcos/ptrto
@mcos
  • @mcos e5738b9
    Minumum 15 pieces of flair.
mcos commented on pull request Rican7/Paulus#15
@mcos

Oh shit, yeah. Ugh. Sorry about that. Good :eyes:

mcos commented on pull request Rican7/Paulus#15
@mcos

Yeah, same. Then I wouldn't be guaranteed that we'd return the right endpoints. e.g. what would a 404 return NotFound, ObjectNotFound or EndpointNo…

mcos pushed to master at mcos/ptrto
@mcos
mcos pushed to master at mcos/ptrto
@mcos
mcos pushed to master at mcos/ptrto
@mcos
mcos pushed to master at mcos/ptrto
@mcos
  • @mcos bdd2bf4
    Initial commit. That was faster than I had planned.
mcos commented on pull request Rican7/Paulus#15
@mcos

Pushed an update and it swallowed some comments. Ugh. @Rican7: I'm almost inclined to suggest calling this StandardHttpExceptionFactory, due to th…

@mcos
mcos commented on pull request Rican7/Paulus#15
@mcos

Yeah, that's a tough one. I'm not sure I love the namespace partials in the classname either. Worth it being ApiExceptionFactory perhaps?

mcos commented on pull request Rican7/Paulus#15
@mcos

Oh cool. I was a little confused. ;-)

mcos opened pull request Rican7/Paulus#15
@mcos
Feature: HTTP Exception Factory
2 commits with 170 additions and 0 deletions
mcos created branch master at mcos/ptrto
mcos created repository mcos/ptrto
mcos starred google/bazel