Please sign in to comment.
Terminate threads before to exit main()
It is very difficult and risky to assure that a running thread doesn't access a global variable. This is currently true, but could change in the future and we don't want to rely on code that works 'by accident'. The threads are still running when ThreadPool destructor is called (after main() returns) and this could lead to crashes if a thread accesses a global that has been already freed. The solution is to use an exit() function and call it while we are still in main(), ensuring global variables are still alive at threads termination time. No functional change. Signed-off-by: Marco Costalba <firstname.lastname@example.org>
- Loading branch information...
Showing with 7 additions and 5 deletions.