Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Now that TT cluster ize is 32bytes and we address TT table by cluster, it is possible to raise the limit to 64GB while still using a uint32_t to index the cluster within teh table. No functional change.
- Loading branch information
be341d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of
size_t
is that it will be 4 bytes on 32-bit machines and 8 bytes on 64-bit machines. That way you don't have to compromise and limit the hash to 64 TB for 64-bit machines, only to preserve performance on 32-bit machines, where the&
is expensive with 64-bit operands.be341d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be341d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a 32-bit system you will fail allocating more than 4GB and SF will crash before first_entry is executed.