Skip to content
Browse files

Remove unnecessary test.

Also, from me: add a comment explaining why the test isn't being done.

Reviewed-by: Guy Harris <guy@alum.mit.edu>
  • Loading branch information...
1 parent f944e1e commit 8dfb278a9530e69f2114d9838c342dee206b5a73 @msekletar msekletar committed with guyharris Oct 13, 2011
Showing with 7 additions and 4 deletions.
  1. +1 −0 CREDITS
  2. +6 −4 print-atm.c
View
1 CREDITS
@@ -127,6 +127,7 @@ Additional people who have contributed patches:
Michael Shalayeff <mickey at openbsd dot org>
Michael Shields <shields at msrl dot com>
Michael T. Stolarchuk <mts at off dot to>
+ Michal Sekletar <msekleta at redhat dot com>
Michele "mydecay" Marchetto <smarchetto1 at tin dot it>
Mike Frysinger <vapier at gmail dot com>
Minto Jeyananth <minto at juniper dot net>
View
10 print-atm.c
@@ -270,10 +270,12 @@ sig_print(const u_char *p, int caplen)
printf(":%s ",
tok2str(msgtype2str, "msgtype#%d", p[MSG_TYPE_POS]));
- if (caplen < CALL_REF_POS+3) {
- printf("[|atm]");
- return;
- }
+ /*
+ * The call reference comes before the message type,
+ * so if we know we have the message type, which we
+ * do from the caplen test above, we also know we have
+ * the call reference.
+ */
call_ref = EXTRACT_24BITS(&p[CALL_REF_POS]);
printf("CALL_REF:0x%06x", call_ref);
} else {

0 comments on commit 8dfb278

Please sign in to comment.
Something went wrong with that request. Please try again.