Add is_quickmix field, remove defaults. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcrute
pushed a commit
that referenced
this pull request
Dec 22, 2015
Add is_quickmix field, remove defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Station.is_quickmixfield, which is used to identify the QuickMix station unambiguously (as opposed to relying on its name being 'QuickMix').Suggest that default values for Fields are removed - as far as I understand Pandora should be setting these to give frontends an indication of which features are supported for each station, track, etc.
If we default values that do not correspond exactly with what the Pandora server has on its side, won't that result in server errors being raised when we later try to execute an unsupported action?