Differentiate between types of search results. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| @@ -292,7 +294,18 @@ class SearchResultItem(PandoraModel): | |||
|
|
|||
| @property | |||
| def is_song(self): | |||
| return self.song_name is not None | |||
| # Song result tokens start with 'S', followed by seven digits. | |||
| return re.compile('^([S])(\d{7})$').match(self.token) | |||
There was a problem hiding this comment.
Would a startswith check work just as well here or is the stronger validation needed? If you do want the extra validation then you should just use re.match('^([S])(\d{7})$', self.token) since python will memoize the complied regex automatically.
There was a problem hiding this comment.
I think startswith would actually be better as I have just come across a few instances where musicToken contains more or fewer digits.
Fixed in 27556ee.
|
Released as 1.7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caters for the three different types of search results, and allows the user to test for each based on the format of
musicToken.