Structure changes #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
pr_comments
branch
3 times, most recently
from
46e9fe1 to
44071a6
Compare
Signed-off-by: fjtirado <ftirados@redhat.com>
fjtirado
force-pushed
the
pr_comments
branch
from
44071a6 to
abf8e11
Compare
fjtirado
commented
Nov 11, 2025
| case ALL -> | ||
| modelFactory.fromAny(new ProcessResult(0, stdout.toString().trim(), stderr.get().trim())); | ||
| case NONE -> modelFactory.fromNull(); | ||
| case CODE -> modelFactory.from(0); |
Author
There was a problem hiding this comment.
Note that exit code, when an exception is not thrown, will be always 0. I need to review if the spec makes sense when handling return values from script
mcruzdev
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):