Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
When attaching files it won't save on sites with Minimal Download Strategy (MDS) enabled #61
This issue was imported from CodePlex
jyanez73 wrote 2017-03-13 at 09:42
SPEasyForms is very nice and well thought.
I have been testing some configurations and detected that when I have a list customized and I attach files the form won't save. When I click the Save button it will be grayed out but nothing happens.
I'm using Sharepoint Foundation 2013 on premise SP1 and CU October 2016 applied.
Maybe I'm missing something?
Thank you very much.
mcsheaj wrote 2017-03-13 at 09:52
jyanez73 wrote 2017-03-13 at 10:28
All three present the same behavior.
I found that the problem only occurs when displaying the site in a non English language (I tried with Spanish that's our case).
mcsheaj wrote 2017-03-15 at 10:48
I'll try spinning up a Spanish site when I get a chance and see what I can see, but the combination of a non-English site and a form where attachments have been added suggests it may not be that simple.
jyanez73 wrote 2017-03-15 at 11:26
Thank you very much for your answer.
What I saw that the FieldName is called Datos adjuntos instead of Attachments.
The tr id is the same, idAttachmentsRow.
mcsheaj wrote 2017-03-15 at 12:28
Quick question: on the form where you are having difficulty, have you moved the attachments field from the default form onto one of my containers? If so, can you try and move it back to the default form and see if you still have the issue?
Also, if you remove the SPEasyForms configuration for that list, does it function correctly? The cleanest way to do this would be to temporarily rename the configuration file in the Site Assets library.
All of this is intended just to give me clues as to where the problem lies.
jyanez73 wrote 2017-03-15 at 13:40
I've tried both options, using containers and not using them leaving every field in the default form and the behavior is the same, it won't save if I attach files.
If I rename the configuration file in the Site Assets library it works correctly and also looses any rules that were attached, meaning that SPEasyForms is not customizing the form. In this case after renaming the configuration file it saves the item with the
Hope this helps.
mcsheaj wrote 2017-03-16 at 09:26
jyanez73 wrote 2017-03-16 at 10:00
Do you thing you can solve this?
Thank you very much.
mcsheaj wrote 2017-03-16 at 11:50
I don't know yet. First I need to reproduce it, which means I need to install a language pack and create a Spanish site, and then I need to try to work in a SharePoint site that uses a language I don't speak, which isn't ideal. And of course, I have a pesky
I should be able to work on this sometime tomorrow, but there are a few ways this can go.
jyanez73 wrote 2017-03-16 at 13:19
Hope you can fix it.
I think you won't have a problem to reproduce it.
It came out in the first test with a regular list with just one rule.
Please let me know if I can help you in any way.
mcsheaj wrote 2017-03-17 at 15:01
None of this is to suggest your problem isn't real, but it is not as simple as Spanish + SPEasyForms + attachments = save doesn't work. I'm pretty stuck.
jyanez73 wrote 2017-03-17 at 16:22
I only tested with custom lists (Lista Personalizada in Spanish). I tried to follow the same instructions as you with a contact list and in Firefox and Chrome I could reproduce the same issue. In Internet Explorer 11 it doesn't customize the list at all, it
Unable to get property 'get_childDialog' of undefined or null reference.
It only happens in IE, but that's another story!
Returning to the original problem, can you try with a custom list with just a Title and only one rule for highlight green (without extra conditions)?
Thank you very much for your time.
jyanez73 wrote 2017-03-17 at 16:24
mcsheaj wrote 2017-03-17 at 17:12
I've very quickly put up a new download page at:
You need to make sure you clear your browser cache (google it, it can be tricky).
This should get rid of that get_childDialog error. I don't have a lot of reason to believe it will fix the other issue too, but it's possible.
jyanez73 wrote 2017-03-17 at 18:33
I replaced the file but it didn't help a lot. It resolved the IE exception but still doesn't configure the form when using a Contact list type. The attachment problem still is the same.
I double checked that it is downloading the new jquery.SPEasyForms.js so no luck with it.
If it's ok with you I will setup the test Sharepoint site to allow you to access remotely as site collection administrator and test directly.
mcsheaj wrote 2017-03-17 at 19:21
jyanez73 wrote 2017-03-20 at 13:47
With your indication the contact list worked in Internet Explorer.
Still has the same issue about attachments that won't allow to save.
mcsheaj wrote 2017-03-30 at 17:53
jyanez73 wrote 2017-03-31 at 10:32
Thank you very much for your answer.
Hope you can fix it in the future.
mcsheaj wrote 2017-03-31 at 13:45
I'm not a fan of MDS. I think it's a messy invasive customization with very dubious merit. Very small customizations to your site can make it actually perform significantly slower with MDS enabled than with it off. Even Microsoft has said that MDS and the publishing
This is actually the first time since 2014.00.xx beta that I've had a reported issue specific to MDS. On the other hand I don't know how many people are using SPEasyForms and attachments, and many people just stop using it if they find an issue and don't report
That makes sense about it not working with or without MDS before that fix, because that's what I thought I was seeing at the time.
MDS being enabled by default on team sites is why I strive to make it work with MDS. I may not like the feature much, but if it's on most of the time I've got to deal with it. I'm still going to be looking for a proper fix, but if I don't find one in a timely fashion, I'll do something like:
in the next release. This is more of a hack than a fix, but it's easy enough to do and still better than not being able to submit.
I'm experiencing the same problem. When creating a dutch SharePoint site the form does'nt save when an attachment is added.
On an English everything works like a charm.
Dutch SharePoint site where:
Is the SharePoint site feature minimal download strategy turned on in any of the sites where you are experiencing this issue (I don't know what the name is in Dutch, but hopefully you do ;)? If so, try turning it off and let me know if it works. If not, let me know that too. So far this hasn't proven to be a language specific issue, although it was first reported as such.
In line 419 & 466 of file "jquery.SPEasyForms.js" you used
I see now that you solved this 'bug' already in GITHUB source code around end of March.
Suggestion: Can you re-create a new WSP and make it available for us somewhere? Your tool a very good, certainly for SP powerusers, but building a new WSP is somehow to advanced for them :).
I will try to get a 2016.01.07 released by the end of the week. Problem is, I try to do a full round of regression testing each time I release so it is time consuming, and I've just been too busy lately. I was also hoping to resolve this issue completely, before releasing (i.e. fix it even with MDS enabled).
I have one idea for how to fix it with MDS enabled, and if it actually works it won't take that much time at all. I'll take a stab at it on Friday. Whether I fix it or not, I'll go ahead and do a release sometime over the weekend. Sorry for the delay, I realize there is no work around for your issue; for the MDS related issue at least there is a work around.
I have fixed the problem due to the hard-coded Save (i.e. English language).
I also believe I've fixed the more general problem with MDS and some non-English sites. By luck, I happened to test a SharePoint 2013 foundation server with just service pack 1 and it did not have this issue. I patched it to Oct 2016 CU and it did, and it continued to have the problem up to Jul 2017 CU. Curiously, I could not reproduce it on SharePoint 2016 at all. In either case I've simplified my preSaveItem handler and the problem has disappeared.
The fix can be found on my blog at http://speasyforms.intellipointsol.com/sdm_downloads/speasyforms-2015-01-07/. I'm going to continue to use GitHub for source code, but I've moved releases over to my blog because I want more control over how they look and download statistics. I've updated the release page on this site to point to the blog. I'll update codeplex soon.
I'm closing this issue. If you find there is still a problem, by all means open another one.