boot: zephyr: Remove legacy serial recovery GPIO configuration #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekPieta
force-pushed
the
mcuboot_sr_fix
branch
from
ed01e40 to
39f6192
Compare
MarekPieta
added a commit
to MarekPieta/sdk-mcuboot
that referenced
this pull request
Sep 13, 2022
Change introduces default values of CONFIG_BOOT_SERIAL_DETECT_PIN and CONFIG_BOOT_USB_DFU_DETECT_PIN. This is needed to prevent build issues caused by uninitialized Kconfig. Upstream PR: mcu-tools/mcuboot#1472 Jira: NCSDK-16550 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no> (cherry picked from commit 01a67d2)
MarekPieta
added a commit
to MarekPieta/sdk-mcuboot
that referenced
this pull request
Sep 13, 2022
…guration Change removes the legacy configuration. The configuration can no longer be used, because GPIO DTS nodes no longer support labels. The GPIO must be configured by board's DTS. Upstream PR: mcu-tools/mcuboot#1472 Jira: NCSDK-16550 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no> (cherry-picked from commit 39f61921c4d005aa7d65f3b6f4dfaec59d485d24)
nvlsianpu
requested changes
Sep 13, 2022
|
|
||
| # MCUboot serial recovery | ||
| CONFIG_MCUBOOT_SERIAL=y | ||
| CONFIG_BOOT_SERIAL_DETECT_PORT="GPIO_0" |
Collaborator
There was a problem hiding this comment.
drop this board patch
this is a unknown board.
Contributor
Author
There was a problem hiding this comment.
Dropped. Btw. should we keep configuration of non-zephyr board in here?
Collaborator
|
2nd commit message: Change removes the legacy configuration. The legacy configuration become problematic as can not The GPIO is preferred to be configured by board's DTS, which is a loot more easier, |
MarekPieta
force-pushed
the
mcuboot_sr_fix
branch
from
39f6192 to
4521045
Compare
Change introduces default values of CONFIG_BOOT_SERIAL_DETECT_PIN and CONFIG_BOOT_USB_DFU_DETECT_PIN. This is needed to prevent build issues caused by uninitialized Kconfig. Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
Change removes the legacy configuration. The legacy configuration became problematic, because GPIO DTS nodes no longer support labels that were used to identify nodes in MCUboot. Therefore we need to use GPIO DTS node name with the legacy approach. The GPIO should be configured by board's DTS, which is simpler. Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no>
MarekPieta
force-pushed
the
mcuboot_sr_fix
branch
from
4521045 to
fda18fd
Compare
nvlsianpu
approved these changes
Sep 13, 2022
MarekPieta
added a commit
to MarekPieta/sdk-mcuboot
that referenced
this pull request
Sep 13, 2022
Change introduces default values of CONFIG_BOOT_SERIAL_DETECT_PIN and CONFIG_BOOT_USB_DFU_DETECT_PIN. This is needed to prevent build issues caused by uninitialized Kconfig. Upstream PR: mcu-tools/mcuboot#1472 Jira: NCSDK-16550 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no> (cherry picked from commit fddbe51b5bd4b400f736b28ed040fe87cf1d969a)
MarekPieta
added a commit
to MarekPieta/sdk-mcuboot
that referenced
this pull request
Sep 13, 2022
…guration Change removes the legacy configuration. The legacy configuration became problematic, because GPIO DTS nodes no longer support labels that were used to identify nodes in MCUboot. Therefore we need to use GPIO DTS node name with the legacy approach. The GPIO should be configured by board's DTS, which is simpler. Jira: NCSDK-16550 Upstream PR: mcu-tools/mcuboot#1472 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no> (cherry picked from commit fda18fdafd1c83bd30a58c41c85344c78b1c80fb)
rlubos
pushed a commit
to nrfconnect/sdk-mcuboot
that referenced
this pull request
Sep 14, 2022
Change introduces default values of CONFIG_BOOT_SERIAL_DETECT_PIN and CONFIG_BOOT_USB_DFU_DETECT_PIN. This is needed to prevent build issues caused by uninitialized Kconfig. Upstream PR: mcu-tools/mcuboot#1472 Jira: NCSDK-16550 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no> (cherry picked from commit fddbe51b5bd4b400f736b28ed040fe87cf1d969a)
rlubos
pushed a commit
to nrfconnect/sdk-mcuboot
that referenced
this pull request
Sep 14, 2022
…guration Change removes the legacy configuration. The legacy configuration became problematic, because GPIO DTS nodes no longer support labels that were used to identify nodes in MCUboot. Therefore we need to use GPIO DTS node name with the legacy approach. The GPIO should be configured by board's DTS, which is simpler. Jira: NCSDK-16550 Upstream PR: mcu-tools/mcuboot#1472 Signed-off-by: Marek Pieta <Marek.Pieta@nordicsemi.no> (cherry picked from commit fda18fdafd1c83bd30a58c41c85344c78b1c80fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change removes the legacy configuration. The configuration can no longer be used, because GPIO DTS nodes no longer support labels. The GPIO must be configured by board's DTS.
PR also adds default values of boot detect pins to prevent build failures.
fixes #1473