From 2631a9985fb4acc3a39f30e679f43726ee604c15 Mon Sep 17 00:00:00 2001 From: Mark Callaghan Date: Mon, 13 Jun 2022 14:49:07 -0700 Subject: [PATCH] Increase num_levels for universal from 8 to 40 Summary: See https://github.com/facebook/rocksdb/issues/10082 for more details. Trivial move isn't done for universal when compaction is from L0 into L0. So a too small value for num_levels with db_bench means there will be fewer trivial moves with universal and that means that write-amp will increase. Test Plan: run it Reviewers: Subscribers: Tasks: Tags: --- tools/benchmark.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/benchmark.sh b/tools/benchmark.sh index 8777129357d..07d3144d85c 100755 --- a/tools/benchmark.sh +++ b/tools/benchmark.sh @@ -233,7 +233,6 @@ const_params_base=" --wal_dir=$WAL_DIR \ \ --num=$num_keys \ - --num_levels=8 \ --key_size=$key_size \ --value_size=$value_size \ --block_size=$block_size \ @@ -271,6 +270,7 @@ const_params_base=" level_const_params=" $const_params_base \ --compaction_style=0 \ + --num_levels=8 \ --min_level_to_compress=$min_level_to_compress \ --level_compaction_dynamic_level_bytes=true \ --pin_l0_filter_and_index_blocks_in_cache=1 \ @@ -295,6 +295,7 @@ blob_const_params=" univ_const_params=" $const_params_base \ --compaction_style=1 \ + --num_levels=40 \ --universal_compression_size_percent=$compression_size_percent \ --pin_l0_filter_and_index_blocks_in_cache=1 \ --universal_min_merge_width=$univ_min_merge_width \