Fix .eslintignore and lint errors #207

Merged
merged 1 commit into from Sep 29, 2016

Projects

None yet

2 participants

@RyanZim
Collaborator
RyanZim commented Sep 28, 2016

The .eslintignore was misconfigured. In an attempt not to validate the browserified bundles, we added ejs.js to the .eslintignore. This not only ignored the bundle, it also ignored lib/ejs.js & test/ejs.js. This line was corrected to read /ejs.js.

As a result of this, quite a few linting errors needed fixed.

I will merge this in a few days if there are no corrections.

@RyanZim RyanZim Fix .eslintignore and lint errors
The .eslintignore was misconfigured. In an attempt not to validate
the browserified bundles, we added `ejs.js` to the .eslintignore.
This not only ignored the bundle, it also ignored `lib/ejs.js` &
`test/ejs.js`. This line was corrected to read `/ejs.js`.

As a result of this, quite a few linting errors needed fixed.
e90dc17
@mde
Owner
mde commented Sep 28, 2016

Could you put the whitespace-only changes into their own commit?

@RyanZim
Collaborator
RyanZim commented Sep 28, 2016

@mde I fixed the .eslintignore, causing the lint script to fail. I ran eslint with the --fix option, which corrected whitespace changes, then manually changed the code to comma-last, one var statement for each variable. I really don't feel like doing it all over, and I'm not sure if eslint auto-fixed non-whitespace changes as well.

@RyanZim
Collaborator
RyanZim commented Sep 28, 2016

I agree that whitespace changes should generally be in their own commit, but I don't like committing in a state where tests/linting is failing either.

@mde
Owner
mde commented Sep 29, 2016

Fair enough, didn't realize these were machine-generated changes.

@mde
Owner
mde commented Sep 29, 2016

LGTM!

@RyanZim RyanZim merged commit 54bb18e into master Sep 29, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@RyanZim RyanZim deleted the eslint branch Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment