Made all the set* and get* functions work to the Date spec. #60

Merged
merged 1 commit into from Feb 11, 2013

Conversation

Projects
None yet
3 participants
Contributor

vogievetsky commented Feb 11, 2013

Wrote the unit tests to test against http://www.ecma-international.org/ecma-262/5.1 and then changed the functions to follow the spec. Pretty much every set* or get* function was changed in the process. All changes except the ones to get/setYear are backwards compatible to the API that was there before.

This closes this issue: #48

longlho added a commit that referenced this pull request Feb 11, 2013

Merge pull request #60 from vogievetsky/master
Made all the set* and get* functions work to the Date spec.

@longlho longlho merged commit aa452ba into mde:master Feb 11, 2013

1 check passed

default The Travis build passed
Details
Collaborator

longlho commented Feb 11, 2013

Thanks :D 👍

Contributor

vogievetsky commented Feb 11, 2013

Wow that was quick! Thank you.

Collaborator

longlho commented Feb 11, 2013

notifications r magic lol

Owner

mde commented Feb 12, 2013

Holy shit, this is nice.

Contributor

vogievetsky commented Feb 12, 2013

Thanks! I am not done though, going to send a couple more PRs soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment