Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Setup bundler. Properly escaped the '&' in the gravatar urls. Bumped …
…version to 1.0.0.pre2
- Loading branch information
Showing
6 changed files
with
21 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
.DS_Store | ||
coverage | ||
rdoc | ||
pkg | ||
pkg | ||
.bundle | ||
Gemfile.lock |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
source :rubygems | ||
|
||
group :development do | ||
gem 'activesupport' | ||
gem 'actionpack' | ||
gem 'jeweler' | ||
gem 'rspec' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
1.0.0.pre1 | ||
1.0.0.pre2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,11 @@ class << self | |
attr_accessor :configuration | ||
end | ||
|
||
def self.configuration | ||
@configuration ||= Configuration.new | ||
end | ||
|
||
def self.configure | ||
self.configuration ||= Configuration.new | ||
yield(configuration) | ||
end | ||
|
||
|
@@ -86,7 +89,7 @@ def self.gravatar_id(email, filetype = nil) | |
|
||
def self.url_params(gravatar_params) | ||
return nil if gravatar_params.keys.size == 0 | ||
"?#{gravatar_params.map { |key, value| "#{key}=#{URI.escape(value.is_a?(String) ? value : value.to_s, Regexp.new("[^#{URI::PATTERN::UNRESERVED}]"))}"}.join('&')}" | ||
"?#{gravatar_params.map { |key, value| "#{key}=#{URI.escape(value.is_a?(String) ? value : value.to_s, Regexp.new("[^#{URI::PATTERN::UNRESERVED}]"))}"}.join('&')}" | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
mdeering
Author
Owner
|
||
end | ||
|
||
end | ||
|
I think that this commit introduced a bug.
Using 1.0.0.pre1, I get source strings like this:
http://gravatar.com/avatar/8bdb05510e492a858b6a5e09ced37f5e?default=identicon&size=40
Works great. But using 1.0.0.pre2, I now get source strings like this:
http://gravatar.com/avatar/69e774f5bdcdde486bfd8a13a4ad63b7?default=identicon&amp;size=40
I'm guessing that the
&amp;
is a result of this commit, but I may be confused.