This repository has been archived by the owner on Oct 26, 2021. It is now read-only.
Properly implement jumpToItem method #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the jumpToItem method would only read a single sheet. However it could be that multiple sheets would hae been involved in getting to the itemCount as provided. The fix was to cleanup the doRead method and to use the doRead method to read upto the correct index. To prevent memory issues, the rowmapper is temporarily being swapped for a noop mapper. Fixes: #13
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the jumpToItem method would
only read a single sheet. However it could be that
multiple sheets would hae been involved in getting
to the itemCount as provided.
The fix was to cleanup the doRead method and to use
the doRead method to read upto the correct index. To
prevent memory issues, the rowmapper is temporarily
being swapped for a noop mapper.
Fixes: #13