From b997ae4bfb8832e3d06ce6ead6ea05a3ee122b0b Mon Sep 17 00:00:00 2001 From: Juergen Hoeller Date: Wed, 21 Jun 2023 09:47:16 +0200 Subject: [PATCH] Ensure Spring LogFactory contains all public methods from Apache LogFactory Closes gh-30668 --- .../org/apache/commons/logging/LogFactoryService.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/spring-jcl/src/main/java/org/apache/commons/logging/LogFactoryService.java b/spring-jcl/src/main/java/org/apache/commons/logging/LogFactoryService.java index 68561d67b5d6..1e961e68f62f 100644 --- a/spring-jcl/src/main/java/org/apache/commons/logging/LogFactoryService.java +++ b/spring-jcl/src/main/java/org/apache/commons/logging/LogFactoryService.java @@ -53,8 +53,9 @@ public Log getInstance(String name) { } - // Just in case some code happens to call uncommon Commons Logging methods... + // Just in case some code happens to rely on Commons Logging attributes... + @Override public void setAttribute(String name, Object value) { if (value != null) { this.attributes.put(name, value); @@ -64,19 +65,19 @@ public void setAttribute(String name, Object value) { } } + @Override public void removeAttribute(String name) { this.attributes.remove(name); } + @Override public Object getAttribute(String name) { return this.attributes.get(name); } + @Override public String[] getAttributeNames() { return this.attributes.keySet().toArray(new String[0]); } - public void release() { - } - }