Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Tree: fcd3131eed
Fetching contributors…

Cannot retrieve contributors at this time

73 lines (49 sloc) 2.709 kB
** Local CVS mirror
First, you will probably want a local CVS mirror. This isn't
necessary, but it significantly speeds up a lot of CVS operations,
which makes using Rietveld much more pleasant.
There are docs on the OpenBSD website that explain how to use cvsync
to setup and maintain one at http://www.openbsd.org/cvsync.html.
** Setting up Rietveld
Next, you'll want to setup the Rietveld upload.py tool. The general
documentation for this is available at
http://code.google.com/p/rietveld/wiki/CodeReviewHelp, but below are
some OpenBSD specific pointers.
First, download the upload.py tool from
http://codereview.appspot.com/static/upload.py. (This tool is
periodically updated, so be sure to check for updates once in a
while.) This is a Python script that expects to run using simply
"python", which doesn't normally exist on an OpenBSD system. The
easiest fix is to change the first line to
"#!/usr/local/bin/python2.7" (or whatever version you install).
To upload to Rietveld, you'll also need a Google account (e.g., a
Gmail account). You can sign up for one at
http://mail.google.com/mail/signup.
** Uploading a diff
To upload a new diff, first change to the base directory and set your
CVSROOT environment variable appropriately if you haven't already:
$ cd /usr/src
$ export CVSROOT=/path/to/cvsmirror
If your change only affects files within a specific subdirectory, you
can cd to that directory (e.g., /usr/src/sys) instead of /usr/src.
However, beware that if you later end up including more files in your
diff and have to change the base directory, Rietveld won't know the
patches refer to the same files.
Next, double check the diff one last time before uploading it:
$ cvs diff -up path/to/file1 path/to/file2 ... | less
Finally, you can use upload.py to actually upload the diff:
$ upload.py --vcs=cvs -y path/to/file1 path/to/file2 ...
(The --vcs=cvs option tells upload.py to not bother autoguessing what
version control tool you're using, and -y tells it to skip trying to
diff the entire checkout for some reason...)
This will prompt you to give a short description of your patch set and
then will upload your diff to codereview.appspot.com.
Additionally, upload.py has a lot of extra command line arguments to
use. Some of the more interesting ones are --reviewers, --send_mail,
--issue, and --private.
E.g., to include me as a reviewer and send me an email notification
about your new issue, you can run:
$ upload.py -r matthew@dempsky.org --send_mail --vcs=cvs -y ...
If you later want to update an existing issue after getting some
feedback, you can run (replacing NNN as appropriate):
$ upload.py -i NNN --send_mail --vcs=cvs -y ...
Jump to Line
Something went wrong with that request. Please try again.