New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build tags #27

Merged
merged 3 commits into from Jul 3, 2018

Conversation

Projects
None yet
4 participants
@yoheimuta
Contributor

yoheimuta commented Jan 1, 2018

closes #21

@yoheimuta yoheimuta changed the title from Allowed buildtag flag to Allow build tags Jan 1, 2018

Show outdated Hide outdated unconvert.go Outdated
Show outdated Hide outdated unconvert.go Outdated
Show outdated Hide outdated unconvert.go Outdated
@yoheimuta

This comment has been minimized.

Show comment
Hide comment
@yoheimuta

yoheimuta Jan 5, 2018

Contributor

Thank you for a review.
I did not know buildutil.TagsFlag, so I fixed it using buildutil.TagsFlag.

Contributor

yoheimuta commented Jan 5, 2018

Thank you for a review.
I did not know buildutil.TagsFlag, so I fixed it using buildutil.TagsFlag.

@mvdan

This comment has been minimized.

Show comment
Hide comment
@mvdan

mvdan commented Jan 17, 2018

Ping @mdempsky?

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Mar 10, 2018

Contributor

Friendly ping @mdempsky. I ran into this need today, but got:

$ unconvert -tags=dev ./...
flag provided but not defined: -tags
usage: unconvert [flags] [package ...]
  -all
    	type check all GOOS and GOARCH combinations
  -apply
    	apply edits to source files
  -cpuprofile string
    	write CPU profile to file
  -safe
    	be more conservative (experimental)
  -v	verbose output
Contributor

dmitshur commented Mar 10, 2018

Friendly ping @mdempsky. I ran into this need today, but got:

$ unconvert -tags=dev ./...
flag provided but not defined: -tags
usage: unconvert [flags] [package ...]
  -all
    	type check all GOOS and GOARCH combinations
  -apply
    	apply edits to source files
  -cpuprofile string
    	write CPU profile to file
  -safe
    	be more conservative (experimental)
  -v	verbose output

@mdempsky mdempsky merged commit 5a7d811 into mdempsky:master Jul 3, 2018

@yoheimuta yoheimuta deleted the yoheimuta:add-buildtag-flag branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment