Skip to content

Conversation

@dakshitagrawal
Copy link
Contributor

This is my application in response to the assignment given after the lecture on Views. Please check for any wrong coding practice or if there can be code improvement and notify me of the same.

Thanks!

@RohanBh RohanBh mentioned this pull request Feb 8, 2017
Copy link

@ajayrahul97 ajayrahul97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to add the strings in strings.xml

setContentView(R.layout.activity_main);

RecyclerView listOfMoviesRecyclerView = (RecyclerView) findViewById(R.id.listOfMovies);
listOfMovies.add(0,new MoviesModel(R.drawable.the_secret_life_of_pets,"The Secret Life of Pets", "18-06-2016"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use strings.xml to store the strings , it can be used elsewhere too.

@kdexd kdexd requested review from deep110 and removed request for deep110 February 10, 2017 04:43
@kdexd kdexd merged commit c69e7ec into master Feb 12, 2017
@kdexd kdexd deleted the dk_lectureAssignments branch February 12, 2017 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants