New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building fails on FreeBSD #53

Closed
dbalan opened this Issue Sep 23, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@dbalan

dbalan commented Sep 23, 2018

Describe the bug
I am trying to build quickDocs on FreeBSD (12-CURRENT), the build fails with type errors.

[3/11] Compiling Vala source ../src/Applica.../PackageList.vala ../src/Widgets/View.vala.
FAILED: src/src@@com.github.mdh34.quickdocs@exe/Application.c src/src@@com.github.mdh34.quickdocs@exe/Constants.c src/src@@com.github.mdh34.quickdocs@exe/MainWindow.c src/src@@com.github.mdh34.quickdocs@exe/Services/Downloader.c src/src@@com.github.mdh34.quickdocs@exe/Widgets/Package.c src/src@@com.github.mdh34.quickdocs@exe/Widgets/PackageList.c src/src@@com.github.mdh34.quickdocs@exe/Widgets/View.c 
valac -C --debug --vapidir /usr/home/dhananjay/code/public/quickDocs/vapi --pkg webkit2gtk-4.0 --pkg libdevhelp-3.0 --pkg libarchive --pkg granite --pkg gtk+-3.0 --pkg gee-0.8 --color=always --directory src/src@@com.github.mdh34.quickdocs@exe --basedir ../src ../src/Application.vala ../src/Constants.vala ../src/MainWindow.vala ../src/Services/Downloader.vala ../src/Widgets/Package.vala ../src/Widgets/PackageList.vala ../src/Widgets/View.vala
../src/Widgets/View.vala:28.17-28.28: warning: `null' incompatible with return type `Gtk.Widget'
                return null;
                ^^^^^^^^^^^^
../src/MainWindow.vala:69.27-69.47: warning: Dh.BookManager.new has been deprecated since 3.26
../src/MainWindow.vala:70.13-70.28: warning: Dh.BookManager.populate has been deprecated since 3.26
../src/Services/Downloader.vala:49.24-49.89: error: 1 extra arguments for `Archive.Result Archive.Read.read_data_block (out weak uint8[], out Archive.int64_t)'
                while (reader.read_data_block (out buffer, out buffer_length, out offset) != Archive.Result.EOF) {
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/Services/Downloader.vala:50.44-50.49: error: Argument 1: Cannot convert from `void*' to `unowned uint8[]'
                    disk.write_data_block (buffer, buffer_length, offset);
                                           ^^^^^^
Compilation failed: 2 error(s), 3 warning(s)
ninja: build stopped: subcommand failed.

To Reproduce

  1. Clone master and try building.

Expected behavior
Should build

System Information

  • Distribution: FreeBSD 12-CURRENT
  • Vala: Vala 0.42.1
  • Desktop Environment: [Xmonad]
  • Installation Method: [From Source.]
@mdh34

This comment has been minimized.

Show comment
Hide comment
@mdh34

mdh34 Sep 23, 2018

Owner

It looks like this is a problem with libarchive, which version do you have installed on your system?

Owner

mdh34 commented Sep 23, 2018

It looks like this is a problem with libarchive, which version do you have installed on your system?

@dbalan

This comment has been minimized.

Show comment
Hide comment
@dbalan

dbalan Sep 23, 2018

libarchive is 3.3.2.

dbalan commented Sep 23, 2018

libarchive is 3.3.2.

@mdh34

This comment has been minimized.

Show comment
Hide comment
@mdh34

mdh34 Sep 23, 2018

Owner

At the moment I've got 3.2.2 so It's possible there was an API break between releases

Owner

mdh34 commented Sep 23, 2018

At the moment I've got 3.2.2 so It's possible there was an API break between releases

@TeddyDD

This comment has been minimized.

Show comment
Hide comment
@TeddyDD

TeddyDD Sep 27, 2018

I can confirm, 2.2.1 fails to build with following env

vala-0.42.2_1: installed.
pkg-config-0.29.2_1: installed.
meson-0.48.0_1: installed.
libarchive-devel-3.3.3_2: installed.
gtk+3-devel-3.24.1_1: installed.
devhelp-devel-3.30.0_1: installed.
webkit2gtk-devel-2.22.2_1: installed.
libgee08-devel-0.20.1_1: installed.
granite-devel-5.1.0_1: installed.

as well as 2.1.1 with granite 0.5

TeddyDD commented Sep 27, 2018

I can confirm, 2.2.1 fails to build with following env

vala-0.42.2_1: installed.
pkg-config-0.29.2_1: installed.
meson-0.48.0_1: installed.
libarchive-devel-3.3.3_2: installed.
gtk+3-devel-3.24.1_1: installed.
devhelp-devel-3.30.0_1: installed.
webkit2gtk-devel-2.22.2_1: installed.
libgee08-devel-0.20.1_1: installed.
granite-devel-5.1.0_1: installed.

as well as 2.1.1 with granite 0.5

@mdh34

This comment has been minimized.

Show comment
Hide comment
@mdh34

mdh34 Oct 3, 2018

Owner

@TeddyDD @dbalan could you try testing the libarchive-updates branch to see if that fixes the issue? - at the moment I'm using Juno which is 18.04 based so I don't have the latest libraries

Edit: the above PR is currently working on fedora 29 beta, which has libarchive 3.3.2-2

Owner

mdh34 commented Oct 3, 2018

@TeddyDD @dbalan could you try testing the libarchive-updates branch to see if that fixes the issue? - at the moment I'm using Juno which is 18.04 based so I don't have the latest libraries

Edit: the above PR is currently working on fedora 29 beta, which has libarchive 3.3.2-2

@TeddyDD

This comment has been minimized.

Show comment
Hide comment
@TeddyDD

TeddyDD Oct 3, 2018

I'll test asap and let you know :)

edit: yup it's fixed, thank you!

TeddyDD commented Oct 3, 2018

I'll test asap and let you know :)

edit: yup it's fixed, thank you!

@mdh34 mdh34 closed this in #55 Oct 4, 2018

@mdh34

This comment has been minimized.

Show comment
Hide comment
@mdh34

mdh34 Oct 4, 2018

Owner

Merged :)

Owner

mdh34 commented Oct 4, 2018

Merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment