New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data for Web Storage API #1187

Merged
merged 4 commits into from Apr 9, 2018

Conversation

Projects
4 participants
@avb100
Contributor

avb100 commented Feb 24, 2018

Add compat data for Web Storage API

avb100 added some commits Feb 24, 2018

Update WebStorage.json
Corrected errors from initial pull request

Style – Use non-localized MDN URL (https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_APIhttps://developer.mozilla.org/docs/Web/API/Web_Storage_API).
  version_added: "10.50" is not a valid version number for opera  → "10.5"

@Elchi3 Elchi3 added this to In Progress / Review Needed in Migration of compat data from MDN pages Feb 27, 2018

"mdn_url": "https://developer.mozilla.org/docs/Web/API/Web_Storage_API",
"support": {
"webview_android": {
"version_added": "2.0"

This comment has been minimized.

@jpmedley

jpmedley Feb 28, 2018

Contributor

Please change to 18. Webview follows Chrome version numbers, not Android version numbers.

Update WebStorage.json
Update webview from 2.0 to 18.
@Elchi3

Requesting changes as per my comment above

@Elchi3

Elchi3 approved these changes Apr 9, 2018

I fixed this up for you. Thanks for your PR!

@Elchi3 Elchi3 merged commit 5355ca9 into mdn:master Apr 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Migration of compat data from MDN pages automation moved this from In Progress / Review Needed to MDN page updates needed Apr 9, 2018

@Elchi3 Elchi3 moved this from MDN page updates needed to Done in Migration of compat data from MDN pages Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment