New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat data for Web Storage API #1187
Conversation
Corrected errors from initial pull request Style – Use non-localized MDN URL (https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API → https://developer.mozilla.org/docs/Web/API/Web_Storage_API). version_added: "10.50" is not a valid version number for opera → "10.5"
api/WebStorage.json
Outdated
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Web_Storage_API", | ||
"support": { | ||
"webview_android": { | ||
"version_added": "2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to 18. Webview follows Chrome version numbers, not Android version numbers.
Update webview from 2.0 to 18.
Hi there! Thanks for contributing to mdn-browser-compat-data! WebStorage is actually this interface https://developer.mozilla.org/en-US/docs/Web/API/Storage So, what we need here is an entry for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes as per my comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this up for you. Thanks for your PR!
Add compat data for Web Storage API