New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data for Presentation #1249

Merged
merged 13 commits into from Apr 10, 2018

Conversation

Projects
4 participants
@LarsBaertschi
Contributor

LarsBaertschi commented Mar 2, 2018

I am not really sure what standard_track for this should be, because it is only a candidate recommendation.

@LarsBaertschi LarsBaertschi changed the title from + Added compat data for Presentation to Add compat data for Presentation Mar 2, 2018

@ExE-Boss

If an interface is defined in any WHATWG or W3C specification, regardless of that specification’s status, the standard_track value is true.

},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ExE-Boss

ExE-Boss Mar 2, 2018

Contributor

This should be true.

},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ExE-Boss

ExE-Boss Mar 2, 2018

Contributor
},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ExE-Boss

ExE-Boss Mar 2, 2018

Contributor
},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ExE-Boss

ExE-Boss Mar 2, 2018

Contributor
},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ExE-Boss

ExE-Boss Mar 2, 2018

Contributor
},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ExE-Boss

ExE-Boss Mar 2, 2018

Contributor
},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ExE-Boss

ExE-Boss Mar 2, 2018

Contributor
},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ExE-Boss

ExE-Boss Mar 2, 2018

Contributor
},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ExE-Boss

ExE-Boss Mar 2, 2018

Contributor
},
"status": {
"experimental": true,
"standard_track": false,

This comment has been minimized.

@ExE-Boss

ExE-Boss Mar 2, 2018

Contributor
@teoli2003

Hi! This is quite good, a few oddities here or there. The only big thing is that we go to much more details: we need an entry for every properties, methods and constructors.

}
}
},
"events": {

This comment has been minimized.

@teoli2003

teoli2003 Mar 3, 2018

Contributor

There should be one entry for each event handler properties.

},
"events": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/close",

This comment has been minimized.

@teoli2003

teoli2003 Mar 3, 2018

Contributor

The url should end in /onXXX

"standard_track": true,
"deprecated": false
}
}

This comment has been minimized.

@teoli2003

teoli2003 Mar 3, 2018

Contributor

Constructors, properties, and methods should be added as sub-features.

"standard_track": true,
"deprecated": false
}
}

This comment has been minimized.

@teoli2003

teoli2003 Mar 3, 2018

Contributor

Constructors, properties, and methods should be added as sub-features.

"standard_track": true,
"deprecated": false
}
}

This comment has been minimized.

@teoli2003

teoli2003 Mar 3, 2018

Contributor

Constructors, properties, and methods should be added as sub-features.

"standard_track": true,
"deprecated": false
}
}

This comment has been minimized.

@teoli2003

teoli2003 Mar 3, 2018

Contributor

Constructors, properties, and methods should be added as sub-features.

"standard_track": true,
"deprecated": false
}
}

This comment has been minimized.

@teoli2003

teoli2003 Mar 3, 2018

Contributor

Constructors, properties, and methods should be added as sub-features.

"standard_track": true,
"deprecated": false
}
}

This comment has been minimized.

@teoli2003

teoli2003 Mar 3, 2018

Contributor

Constructors, properties, and methods should be added as sub-features.

"standard_track": true,
"deprecated": false
}
}

This comment has been minimized.

@teoli2003

teoli2003 Mar 3, 2018

Contributor

Constructors, properties, and methods should be added as sub-features.

"standard_track": true,
"deprecated": false
}
}

This comment has been minimized.

@teoli2003

teoli2003 Mar 3, 2018

Contributor

Constructors, properties, and methods should be added as sub-features.

@Elchi3 Elchi3 added this to In Progress / Review Needed in Migration of compat data from MDN pages Mar 5, 2018

Elchi3 added some commits Apr 10, 2018

Delete PresentationConnectionClosedEvent
This was renamed to PresentationConnectionCloseEvent, I also redirected the MDN page
@Elchi3

Elchi3 approved these changes Apr 10, 2018

I've updated the files to contain the sub features of the Presentation API interfaces. Thanks for contributing to MDN browser-compat-data!

comments addressed

@Elchi3 Elchi3 merged commit d43561f into mdn:master Apr 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Migration of compat data from MDN pages automation moved this from In Progress / Review Needed to MDN page updates needed Apr 10, 2018

@Elchi3 Elchi3 moved this from MDN page updates needed to Done in Migration of compat data from MDN pages Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment