Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webextensions.onCommand.tab #12512

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Add webextensions.onCommand.tab #12512

merged 3 commits into from
Nov 30, 2021

Conversation

bershanskiy
Copy link
Contributor

Summary

Add compatibility data for WebExtension Commands API callback arguments. Specifically, this adds the second tab argument. onCommand.name.__compat is taken from onCommand.__compat.

Test results and supporting details

Chromium docs showing "Chrome 86+" next to tabs.

Related issues

@github-actions github-actions bot added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Sep 21, 2021
@bershanskiy
Copy link
Contributor Author

May I do anything to advance this PR?

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ddbeck ddbeck merged commit 9b56d58 into mdn:main Nov 30, 2021
@bershanskiy bershanskiy deleted the webextensions.onCommand.tab branch November 30, 2021 13:51
queengooborg added a commit to queengooborg/browser-compat-data that referenced this pull request Aug 10, 2024
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `Command.name` member of the `commands` Web Extensions interface. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD.

Commit/PR Adding the Feature: mdn#12512
queengooborg added a commit that referenced this pull request Aug 21, 2024
)

This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `Command.name` member of the `commands` Web Extensions interface. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD.

Commit/PR Adding the Feature: #12512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants