New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Functional syntax with floats value notations #1342

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
4 participants
@teoli2003

This comment has been minimized.

Contributor

teoli2003 commented Mar 13, 2018

And the error is because you put null between "quotes" for opera. Remove the quotes and the test will be passed (and I will be able to review this).

@jpmedley

This comment has been minimized.

Contributor

jpmedley commented Mar 13, 2018

I'm preparing the beta blog post for Chrome 66 right now and I don 't recognize this. Let me double-check this before merging.

@yisibl

This comment has been minimized.

Contributor

yisibl commented Mar 13, 2018

@jpmedley I'm not sure which version of this will be released.
https://bugs.chromium.org/p/chromium/issues/detail?id=703898

@jpmedley

Someone on our side didn't fill out their paperwork. You are correct this is in Chrome 66. I'm not crazy about how you've described this feature here. I think "Allow floats in rgb() and rgba()" would be more straight forward.

"description": "Functional syntax with floats value notations",
"support": {
"webview_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Mar 13, 2018

Contributor

"66"

"version_added": "66"
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Mar 13, 2018

Contributor

"66"

@teoli2003

Thanks a lot, with the Chromia version numbers and the small description/id changes, we will be ready to land this.

},
"functional_syntax_with_floats_notation": {
"__compat": {
"description": "Functional syntax with floats value notations",

This comment has been minimized.

@teoli2003

teoli2003 Mar 14, 2018

Contributor

I like @jpmedley proposal here. ""Allow floats in rgb() and rgba()""

@@ -552,6 +552,54 @@
"deprecated": false
}
}
},
"functional_syntax_with_floats_notation": {

This comment has been minimized.

@teoli2003

teoli2003 Mar 14, 2018

Contributor

"floats_in_rgb_rgba"

@yisibl

This comment has been minimized.

Contributor

yisibl commented Mar 14, 2018

Thank you for your advice. I retested it to confirm that it was Chrome 67.

@Elchi3

Elchi3 approved these changes Apr 11, 2018

Thanks a lot for your pull request! Sorry, this took so long to merge!

comments are all addressed

@Elchi3 Elchi3 merged commit 20adbdf into mdn:master Apr 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment