New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: add calc() values in grid-gap(gutter properties) #1378

Merged
merged 2 commits into from Apr 12, 2018

Conversation

Projects
None yet
5 participants
@yisibl
Contributor

yisibl commented Mar 15, 2018

See also MDN changes: https://developer.mozilla.org/en-US/docs/Web/CSS/grid-gap$compare?locale=en-US&to=1367223&from=1359654

Chrome bug: https://bugs.chromium.org/p/chromium/issues/detail?id=816300#c3 (It may land to Chrome 68 https://omahaproxy.appspot.com/)

It also needs to be updated grid-column-gap and grid-row-gap

In addition, Chrome supported <percentage> value very early: https://bugs.chromium.org/p/chromium/issues/detail?Id=615248

"version_added": "68"
},
"chrome_android": {
"version_added": "68"

This comment has been minimized.

@jpmedley

jpmedley Mar 15, 2018

Contributor

chrome and chrome_android should be false. Chrome 68 won't even be in canary for another six weeks yet. Even then, there's no guarantee this will stay in 68 all the way to stable.

@jpmedley

This comment has been minimized.

Contributor

jpmedley commented Mar 15, 2018

Omaha Proxy has this in 67 actually. https://storage.googleapis.com/chromium-find-releases-static/35d.html#35d044cf27bde7781ab720f20803e35c07ee833d

Even so, I'm never confident that anything in canary will make it to stable. If they find a regression they can't fix before feature freeze, they will pull it.

@yisibl

This comment has been minimized.

Contributor

yisibl commented Mar 15, 2018

@jpmedley That's true, so I'm not sure whether 68 will land this function. And now write 68, the github CI can't pass.

@mrego Can you help me confirm it?

@mrego

This comment has been minimized.

mrego commented Mar 15, 2018

calc() was supported earlier but there was a bug that was detected recently.
I'm fairly confident that the change will be included in 67.

And I've just requested to merge it in 66 too, but I'm not sure if that would happen.

@yisibl

This comment has been minimized.

Contributor

yisibl commented Mar 16, 2018

@mrego Thank you for the reply, it doesn't seem to fall to 66.

@mrego

This comment has been minimized.

mrego commented Mar 16, 2018

@mrego Thank you for the reply, it doesn't seem to fall to 66.

Yep, that specific case calc(10px + 10%) will only work in 67.
Other cases like calc(10px + 10px) will work though.

@jpmedley

This comment has been minimized.

Contributor

jpmedley commented Mar 23, 2018

All three flavors of Chrome need to say false.

@yisibl

This comment has been minimized.

Contributor

yisibl commented Mar 27, 2018

I've updated it.

"version_added": "67"
},
"chrome_android": {
"version_added": "67"

This comment has been minimized.

@jpmedley

jpmedley Mar 27, 2018

Contributor

These should say false.

"version_added": "54"
},
"opera_android": {
"version_added": "54"

This comment has been minimized.

@jpmedley

jpmedley Mar 27, 2018

Contributor

These should also say false.

@Elchi3

Elchi3 approved these changes Apr 12, 2018

I've marked the Chrome and Opera browsers as false for now. We can always update if the situation changes or we have clarity about the versions there.

@Elchi3 Elchi3 merged commit a0c1dab into mdn:master Apr 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment