New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLEmbedElement #1399

Merged
merged 8 commits into from Apr 12, 2018

Conversation

Projects
None yet
2 participants
@jmswisher
Member

jmswisher commented Mar 16, 2018

Adding a JSON file for HTMLEmbedElement API

@Elchi3

Thanks for your PR!

There are two .DS_Store files that shouldn't be committed and I don't know if you intended to do both HTMLEmbedElement and HTMLFontElement in this PR (would be fine, haven't check if another PR does HTMLFontElement, though).

Two more comments inline.

@@ -1,8 +1,8 @@
{
"api": {
"HTMLBodyElement": {
"HTMLEmbdElement": {

This comment has been minimized.

@Elchi3

Elchi3 Mar 17, 2018

Member

I guess these changes to HTMLBodyElement -> HTMLEmbdElement were just for testing purposes? Can you undo this?

},
"firefox": {
"version_added": "1",
"notes": "(Gecko 1.7 or earlier)"

This comment has been minimized.

@Elchi3

Elchi3 Mar 17, 2018

Member

We stopped talking about Gecko on MDN and we disallow it in BCD. Please remove the note.

Elchi3 added some commits Apr 12, 2018

@Elchi3

Elchi3 approved these changes Apr 12, 2018

I fixed up the remaining issues here. Thank you, Janet! 👍

@Elchi3 Elchi3 merged commit 15d7d09 into mdn:master Apr 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment