Edge webextension api version updates by mattwojo · Pull Request #1486 · mdn/browser-compat-data

mattwojo · 2018-03-16T23:21:34Z

No description provided.

ExE-Boss · 2018-03-16T23:25:03Z

+                  "version_added": "14",
+                  "notes": [
+                  "storage.local data is persisted in a different format than Chrome, causing a different value to be returned when calling storage.local.getBytesInUse. Ex: storage.local.set({ "k": { "s": "âas" } } returns 13 in Chrome and 50 in Microsoft Edge.",
+                ]


The +es at the beginning of the lines are causing JSON parsing errors.

ExE-Boss · 2018-03-16T23:25:15Z

+                "version_added": "14",
+                "notes": [
+                  "After uninstall/reinstall, the URL is not received until Microsoft Edge is restarted."
+                ]


ExE-Boss · 2018-03-16T23:25:21Z

+                "version_added": "14",
+                "notes": [
+                  "`pinned` and `muted` are not yet supported. `highlighted` and `selected` are not supported."
+                ]


ExE-Boss · 2018-03-16T23:25:34Z

+                  "Network requests from extensions, such as options, background or popup pages, are not supported.",
+                   "Network requests from <object> and <embed> elements are not supported.",
+                   "Headers cannot be modified for cached requests."
+                ]


ExE-Boss · 2018-03-16T23:48:58Z

-+                  "storage.local data is persisted in a different format than Chrome, causing a different value to be returned when calling storage.local.getBytesInUse. Ex: storage.local.set({ "k": { "s": "âas" } } returns 13 in Chrome and 50 in Microsoft Edge.",
-+                ]
+                  "storage.local data is persisted in a different format than Chrome, causing a different value to be returned when calling storage.local.getBytesInUse."
+                ]


These lines have wrong indentation.

ExE-Boss · 2018-03-16T23:49:14Z

+                  "`webRequest` not supported for synchronous XmlHttpRequests.",
+                  "Network requests from extensions, such as options, background or popup pages, are not supported.",
                   "Network requests from <object> and <embed> elements are not supported.",
                   "Headers cannot be modified for cached requests."


ExE-Boss · 2018-03-17T00:01:41Z

                  "notes": [
-                  "storage.local data is persisted in a different format than Chrome, causing a different value to be returned when calling storage.local.getBytesInUse."
+                  "<code>storage.local</code> data is persisted in a different format than Chrome, causing a different value to be returned when calling <code>storage.local.getBytesInUse</code>."
                ]


These lines still have the wrong indentation.

wbamberg

Thanks, this is an awesome PR! I had a few comments.

I don't know in general how to get detailed version info for Edge, or any detailed Edge compat info really beyond https://docs.microsoft.com/en-us/microsoft-edge/extensions/api-support/supported-apis.

14 seems like a reasonable baseline, so in general "true"->"14" seems like a good change. There are a few instances where you have changed "15"->"14" - I assume these are correct too, but please make sure :-)

wbamberg · 2018-03-17T08:54:03Z

-                "version_added": true
+                "version_added": true,
+                "notes": [
+                  "tab object in runtime.onMessage event is not fully implemented.",


This doesn't seem like a very helpful note, is it possible to be more specific about what isn't supported?

wbamberg · 2018-03-17T08:57:42Z

                },
                "edge": {
-                  "version_added": false
+                  "version_added": "14"


https://docs.microsoft.com/en-us/microsoft-edge/extensions/api-support/supported-apis#webnavigation, in the summary at the top, says transition types are not supported, but the entry for TransitionType does not. I don't know which is correct here.

wbamberg · 2018-03-17T08:59:33Z

-                "version_added": true
+                "version_added": "14",
+                "notes": [
+                  "webRequest not supported for synchronous XmlHttpRequests."


"webRequest not supported for synchronous XmlHttpRequests." -> "webRequest events are not fired for synchronous XMLHttpRequests." or something like that?

wbamberg · 2018-03-17T09:00:52Z

                "notes": [
-                  "Asynchronous event listeners are not supported."
+                  "Asynchronous event listeners are not supported.",
+                  "`requestBody` is not supported."


Should use <code>requestBody</code>, or just plaintext. Markdown is not supported in notes (yes I know lots of existing notes use it :-/

ExE-Boss

This could probably be merged with my effort in #1686.

Elchi3 · 2018-04-19T14:55:19Z

This needs a rebase now that #1686 is merged.

Elchi3 · 2018-07-19T08:37:22Z

No activity here, so I'm closing this now. Please re-open if you want to come back to it.

mattwojo added 12 commits March 16, 2018 15:13

Edge version updates for browserAction API

e2f08aa

Update Edge version numb on cookies extension API

121f796

Additional cookies API extension Edge version numb update

9f97e51

Edge extension api version numb update

224b98f

Add Edge version numb to extension i18n api

cc96bc6

Added Edge version numb to extension pageAction api

ee19e75

Updates to Edge version numb for extension runtime api

69f82ef

Update Edge version numb for extension storage api

90d9ab4

Edge extension version updates to tabs api

fe82809

Edge Extension version support updates to webNavigation api

6d5dc4f

Edge extension version updates to webRequest api

d76c47f

Edge extensions update versions for windows api

db27e1e

ExE-Boss suggested changes Mar 16, 2018

View reviewed changes

mattwojo added 3 commits March 16, 2018 16:37

Removed +es

ad790de

Fix JSON syntax error for Edge version update

b74d8ec

Remove note brackets in webRequest api

2bd1170

ExE-Boss suggested changes Mar 16, 2018

View reviewed changes

mattwojo added 2 commits March 16, 2018 16:55

Remove error caused by note

13dc5af

Fix note in storage api

3f55398

ExE-Boss suggested changes Mar 17, 2018

View reviewed changes

Removed note causing an error

ebd0388

teoli2003 added data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions HackOnMDNParis2018 Issues or pull requests at the Hack on MDN event in Paris in March 2018 labels Mar 17, 2018

Elchi3 requested a review from wbamberg March 17, 2018 07:29

wbamberg requested changes Mar 17, 2018

View reviewed changes

ExE-Boss reviewed Apr 8, 2018

View reviewed changes

ExE-Boss approved these changes Apr 8, 2018

View reviewed changes

ExE-Boss mentioned this pull request Apr 8, 2018

Complete Microsoft Edge support for WebExtension APIs #1686

Merged

Elchi3 added the rebase-needed 🚧 label Apr 19, 2018

Elchi3 closed this Jul 19, 2018

Conversation

mattwojo commented Mar 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ExE-Boss Mar 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ExE-Boss Mar 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ExE-Boss Mar 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wbamberg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ExE-Boss left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Elchi3 commented Apr 19, 2018

Uh oh!

Elchi3 commented Jul 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ExE-Boss Mar 16, 2018 •

edited

Loading

ExE-Boss Mar 16, 2018 •

edited

Loading

ExE-Boss Mar 16, 2018 •

edited

Loading

ExE-Boss left a comment •

edited

Loading