New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big ol' PR to populate a lot of Samsung Internet data. #1606

Merged
merged 7 commits into from Apr 10, 2018

Conversation

Projects
None yet
3 participants
@AdaRoseCannon
Contributor

AdaRoseCannon commented Mar 18, 2018

This used a script to generate the Samsung Internet data by matching versions with the Chrome Android version. With some extra massaging by hand for more complex data.

Ada Rose Cannon
@AdaRoseCannon

This comment has been minimized.

Contributor

AdaRoseCannon commented Mar 23, 2018

Rebase done.

AdaRoseCannon and others added some commits Mar 23, 2018

Ada Rose Cannon
Ada Rose Cannon
Update link.json
Correct Noopener
@AdaRoseCannon

This comment has been minimized.

Contributor

AdaRoseCannon commented Apr 9, 2018

@Elchi3 Fixed the conflicts :)

@Elchi3

This comment has been minimized.

Member

Elchi3 commented Apr 9, 2018

We should probably just merge this. I spot checked it here and there and it seems fine 😅
Also, I think this wouldn't actually cause a whole lot of other PRs to become merge-conflicted.

@Elchi3 Elchi3 merged commit 5133d14 into mdn:master Apr 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AdaRoseCannon

This comment has been minimized.

Contributor

AdaRoseCannon commented Apr 10, 2018

OMG AWESOME! Thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment