Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chrome/Opera versions for RTCPeerConnection.getSenders #1713

Merged
merged 1 commit into from Apr 5, 2018

Conversation

Projects
None yet
3 participants
@jlaine
Copy link
Contributor

jlaine commented Mar 30, 2018

Chrome only supports getSenders from version 64 onwards, see:

https://www.chromestatus.com/feature/5644723490390016

Opera only supports getSenders from version 51 onwards, see:

https://dev.opera.com/blog/opera-51/

The comment about a "promise-based version" was just plain wrong, there
never was a promise-based getSenders. It looks as though it was copy-pasted
from some other feature.

Fix Chrome/Opera versions for RTCPeerConnection.getSenders
Chrome only supports getSenders from version 64 onwards, see:

  https://www.chromestatus.com/feature/5644723490390016

Opera only supports getSenders from version 51 onwards, see:

  https://dev.opera.com/blog/opera-51/

The comment about a "promise-based version" was just plain wrong, there
never was a promise-based getSenders. It looks as though it was copy-pasted
from some other feature.

@Elchi3 Elchi3 added the data:api 🐇 label Apr 4, 2018

@Elchi3

Elchi3 approved these changes Apr 5, 2018

Copy link
Member

Elchi3 left a comment

Thank you!
And yes, likely copy-paste from elsewhere. We're mass-editing/migrating the data right now and this can easily happen sometimes.

@Elchi3 Elchi3 merged commit 7965806 into mdn:master Apr 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.