Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding compat data for Comment #1736

Merged
merged 2 commits into from Apr 19, 2018

Conversation

Projects
None yet
3 participants
@katzrkool
Copy link
Contributor

katzrkool commented Apr 5, 2018

No description provided.

@Elchi3 Elchi3 added the data:api 🐇 label Apr 5, 2018

"mdn_url": "https://developer.mozilla.org/docs/Web/API/Comment",
"support": {
"chrome": {
"version_added": "1"

This comment has been minimized.

@jpmedley

jpmedley Apr 6, 2018

Contributor

chrome_android is missing. It should be true.

"description": "<code>Comment()</code> constructor",
"support": {
"chrome": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Apr 6, 2018

Contributor

true

There should also be"chrome_android": true

"version_added": false
},
"opera": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Apr 6, 2018

Contributor

true

"version_added": "24"
},
"opera_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Apr 6, 2018

Contributor

ditto

@katzrkool

This comment has been minimized.

Copy link
Contributor Author

katzrkool commented Apr 6, 2018

fixed, thanks

@Elchi3

Elchi3 approved these changes Apr 19, 2018

Copy link
Member

Elchi3 left a comment

Hey, thanks for contributing to MDN browser-compat-data! 👍 This PR looks good to me! Thanks for submitting it and making requested changes. This is good to get merged now! 🎉

@Elchi3 Elchi3 merged commit fbdc5d9 into mdn:master Apr 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@katzrkool katzrkool deleted the katzrkool:comment branch Jul 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.