New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -webkit-progress-* psuedo-selectors #1748

Merged
merged 2 commits into from Apr 17, 2018

Conversation

Projects
None yet
3 participants
@connorshea
Contributor

connorshea commented Apr 6, 2018

Add compat data for -webkit-progress-value, -webkit-progress-bar, -we…
…bkit-progress-inner-element psuedo-selectors.
@connorshea

This comment has been minimized.

Contributor

connorshea commented Apr 6, 2018

I should note that this PR (along with #1749 and #1750) assumes that the vendor prefix doesn't need to be split into a prefix property when it's only supported by one browser engine and there's no standardization effort for the feature.

I did my PR based on how css/properties/-webkit-text-stroke-color.json currently works in master.

From the Compatibility Tables docs on MDN:

If a feature is supported behind a vendor prefix in one or more browsers, you'll want to make that clear in the browser compat data.

Should the documentation be updated, or should I change my PRs?

@ExE-Boss

Non-standard properties and selectors (i.e. everything in the Prefix pages block) have the file prefixed as well.

@Elchi3 Elchi3 added the data:css 🎨 label Apr 9, 2018

@Elchi3

This comment has been minimized.

Member

Elchi3 commented Apr 17, 2018

assumes that the vendor prefix doesn't need to be split into a prefix property when it's only supported by one browser engine and there's no standardization effort for the feature.

Yes, this understanding is exactly right.

@Elchi3

Elchi3 approved these changes Apr 17, 2018

Looks good to me, thank you! 👍

@Elchi3 Elchi3 merged commit 2e92d31 into mdn:master Apr 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@connorshea connorshea deleted the connorshea:add-progress-bar branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment