New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web APIs: add HashChangeEvent #1759

Merged
merged 4 commits into from Apr 26, 2018

Conversation

Projects
None yet
3 participants
@caugner
Contributor

caugner commented Apr 10, 2018

"mdn_url": "https://developer.mozilla.org/docs/Web/API/HashChangeEvent",
"support": {
"webview_android": {
"version_added": "2.2"

This comment has been minimized.

@jpmedley

jpmedley Apr 13, 2018

Contributor

Change this to true. Webview follows Chrome version numbers, not Android version numbers. (It's probably 5, but I can't confirm something that old, so true.)

"version_added": "5"
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Apr 13, 2018

Contributor

This should be true.

"version_added": null
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Apr 13, 2018

Contributor

true for all 3 flavors of Chrome.

"version_added": null
},
"opera_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Apr 13, 2018

Contributor

true for both flavors of Opera.

"version_added": null
},
"chrome_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Apr 13, 2018

Contributor

true for all 3.

"version_added": null
},
"opera_android": {
"version_added": null

This comment has been minimized.

@jpmedley

jpmedley Apr 13, 2018

Contributor

true for both.

@caugner

This comment has been minimized.

Contributor

caugner commented Apr 19, 2018

I have just incorporated the suggested changes from @jpmedley (thank you!), so this is ready to be merged from my side.

@Elchi3

Elchi3 approved these changes Apr 26, 2018

Thanks, nice work! 🎉

@Elchi3 Elchi3 merged commit 060331b into mdn:master Apr 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@caugner caugner deleted the caugner:web-apis/hashchangeevent branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment