-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes for action.openPopup API in Firefox #18202
Conversation
webextensions/api/action.json
Outdated
"version_added": "101" | ||
"version_added": "101", | ||
"notes": [ | ||
"Must be called from inside the handler for a <a href='https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/User_actions'>user action</a>. From Firefox 108, this restriction has been lifted behind a preference. See <a href='https://bugzil.la/1799344'>bug 1799344</a>.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, I'd just shorten this to "Since Firefox 108, user interaction is no longer required to call this API."
Now, since the pref is required, maybe also ... when the ... pref is set (<a ...>bug xxx</a>).
When the pref is finally flipped, we could do something like this:
browser-compat-data/webextensions/api/identity.json
Lines 63 to 67 in 2687c37
"notes": [ | |
"Since Firefox 86, the <code>redirect_url</code> parameter now supports a loopback address, see <a href='https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/identity#getting_the_redirect_url'>Getting the redirect URL</a> for details.", | |
"Between Firefox 75 and Firefox 86, the <code>redirect_uri</code> URL parameter must be set to the URL returned by <code>identity.getRedirectURL()</code>.", | |
"Between Firefox 63 and Firefox 75, the <code>redirect_uri</code> URL parameter was optional." | |
] |
... or just keep the minimal simple text from the top of this comment, without any reference to a preference, since the preference (flag) would be irrelevant: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#removal-of-irrelevant-flag-data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I pushed a change :)
Hey @oliverdunk, I just noticed that this was your first PR for BCD -- welcome to the project (sorry that you weren't welcomed sooner)! If you have any questions, don't hesitate to ask a project peer or owner! |
Thanks @queengooborg! And apologies for the delay, I’m slowly catching up on responding to feedback 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick changes, let's get this merged!
Summary
Updates the compatibility information for the WebExtension
action.openPopup
API following the changes in https://phabricator.services.mozilla.com/D139796. In particular, Firefox now has support for awindowId
parameter and the user gesture requirement has been removed behind a preference currently enabled in Nightly.I have a similar PR coming to update the main MDN page, which this one is intended to land at the same time as.
Test results and supporting details
Original bug (including
windowId
support): https://bugzilla.mozilla.org/show_bug.cgi?id=1755763Removing preference: https://bugzilla.mozilla.org/show_bug.cgi?id=1799344
I've been working on these changes with @Rob--W.
Related issues
NA