Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `prefix` and `alternative_name` mutually exclusive #1836

Merged
merged 2 commits into from Apr 19, 2018

Conversation

Projects
None yet
2 participants
@ExE-Boss
Copy link
Contributor

ExE-Boss commented Apr 19, 2018

It doesn’t make sense to allow both, and it doesn’t seem reasonably1 used.

Edit:

Footnote 1
Apparently, user‑select uses this for some very odd reason, but in a way that makes no sense, and it seems more like a footgun.

Depends on #1837

@Elchi3

This comment has been minimized.

Copy link
Member

Elchi3 commented Apr 19, 2018

Yeah, the user-select case seems very odd.
Generally, this more strict rule makes sense I think. Good idea!

@ExE-Boss ExE-Boss referenced this pull request Apr 19, 2018

Merged

Correct `user-select` #1837

@Elchi3

Elchi3 approved these changes Apr 19, 2018

Copy link
Member

Elchi3 left a comment

Thanks for rebasing! Let's get this in :)

@Elchi3 Elchi3 merged commit 779de77 into mdn:master Apr 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ExE-Boss ExE-Boss deleted the ExE-Boss:schema/compat-data/prefix-alternative_name branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.