New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font element compat data according Caniuse. #1880

Merged
merged 2 commits into from Apr 26, 2018

Conversation

Projects
None yet
3 participants
@myfonj
Contributor

myfonj commented Apr 20, 2018

  • Data taken from Fyrd/caniuse/blob/1ec4dcc442399a70d7ed2000c0d8a344438e23cf/features-json/svg-fonts.json
@Elchi3

This comment has been minimized.

Member

Elchi3 commented Apr 26, 2018

Can you review this @JeremiePat?

@JeremiePat

This comment has been minimized.

Contributor

JeremiePat commented Apr 26, 2018

LGTM :)

@JeremiePat

This comment has been minimized.

Contributor

JeremiePat commented Apr 26, 2018

It can be merge as is. However, it should be safe to assume that browsers that never supported the <font> element (like Edge and IE) had never supported the associated attributes as well and they could be set to false.

@Elchi3

This comment has been minimized.

Member

Elchi3 commented Apr 26, 2018

I agree and we're thinking about advanced parent<->children validation in #1618 which could catch these kind of things at the linter level.

@Elchi3

Elchi3 approved these changes Apr 26, 2018

👍

@Elchi3 Elchi3 merged commit dac2a7c into mdn:master Apr 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment